feat(google-maps): add heatmap support#21489
Conversation
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM, though @mbehrlich should also take a look
| } | ||
|
|
||
| if (changes['data'] && _data !== undefined) { | ||
| // TODO(crisbeto): the API allows for `MVCArray<LatLng|WeightedLocation>` or |
There was a problem hiding this comment.
Is it worth sending a PR to fix the types?
There was a problem hiding this comment.
Yeah, I was planning on sending out out, but I haven't gotten around to it yet.
There was a problem hiding this comment.
Here we go DefinitelyTyped/DefinitelyTyped#50423.
| </head> | ||
| ``` | ||
|
|
||
| **Note:** |
There was a problem hiding this comment.
There are several classes that we may want to implement in the future that also require adding separate libraries. Should we make this note more general, to apply to several components, while giving more specific instructions about which library to use in the component-specific readme?
There was a problem hiding this comment.
I think it may be too vague if we're doing it now since there aren't any other components that use this approach. It might be better to do it once we have other components.
crisbeto
force-pushed
the
google-heatmap
branch
2 times, most recently
from
87d2c81 to
c17ec2b
Compare
crisbeto
force-pushed
the
google-heatmap
branch
2 times, most recently
from
a3a1266 to
cc428ad
Compare
crisbeto
force-pushed
the
google-heatmap
branch
from
cc428ad to
666bf4b
Compare
crisbeto
force-pushed
the
google-heatmap
branch
from
666bf4b to
7fd36f4
Compare
|
@crisbeto needs rebase |
Adds support for rendering heatmaps on the `google-map` component using the `map-heatmap-layer` directive. The directive is mostly a direct wrapper around the `google.maps.visualization.HeatmapLayer` class, except for the fact that it also accepts a `LatLngLiteral`, whereas the Google Maps class only accepts `LatLng` objects. I decided to add some logic to convert them automatically, because creating `LatLng` requires the Maps API to have been loaded which can lead to race conditions if it's being loaded lazily.
crisbeto
force-pushed
the
google-heatmap
branch
from
7fd36f4 to
2acb4aa
Compare
|
Rebased @annieyw. |
Adds support for rendering heatmaps on the `google-map` component using the `map-heatmap-layer` directive. The directive is mostly a direct wrapper around the `google.maps.visualization.HeatmapLayer` class, except for the fact that it also accepts a `LatLngLiteral`, whereas the Google Maps class only accepts `LatLng` objects. I decided to add some logic to convert them automatically, because creating `LatLng` requires the Maps API to have been loaded which can lead to race conditions if it's being loaded lazily.
Adds support for rendering heatmaps on the `google-map` component using the `map-heatmap-layer` directive. The directive is mostly a direct wrapper around the `google.maps.visualization.HeatmapLayer` class, except for the fact that it also accepts a `LatLngLiteral`, whereas the Google Maps class only accepts `LatLng` objects. I decided to add some logic to convert them automatically, because creating `LatLng` requires the Maps API to have been loaded which can lead to race conditions if it's being loaded lazily.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Adds support for rendering heatmaps on the
google-mapcomponent using themap-heatmap-layerdirective. The directive is mostly a direct wrapper around thegoogle.maps.visualization.HeatmapLayerclass, except for the fact that it also accepts aLatLngLiteral, whereas the Google Maps class only acceptsLatLngobjects. I decided to add some logic to convert them automatically, because creatingLatLngrequires the Maps API to have been loaded which can lead to race conditions if it's being loaded lazily.