build: add tsickle as explicit dependency#18116
Merged
mmalerba merged 1 commit intoangular:masterfrom Jan 9, 2020
Merged
Conversation
Adds tsickle as explicit dependency. This is necessary because we access it from `node_modules/tsickle` in a Bazel target that wraps tsc with tsickle. In the past we just relied on the transitive dependency of `@angular/bazel` being hoisted, but the hoisting is not guaranteed if the lock file changes (e.g. when running `yarn upgrade`). In general, dependencies we explicitly access, should be added as explicit dependencies.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
crisbeto
reviewed
Jan 7, 2020
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
Shouldn't the lock file be updated as well?
Member
Author
|
@crisbeto The lock file doesn't change. This is a pure |
14 tasks
devversion
added
pr: lgtm
action: merge
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
Adds tsickle as explicit dependency. This is necessary because we access it from `node_modules/tsickle` in a Bazel target that wraps tsc with tsickle. In the past we just relied on the transitive dependency of `@angular/bazel` being hoisted, but the hoisting is not guaranteed if the lock file changes (e.g. when running `yarn upgrade`). In general, dependencies we explicitly access, should be added as explicit dependencies.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tsickle as explicit dependency. This is necessary because
we access it from
node_modules/tsicklein a Bazel target thatwraps tsc with tsickle.
In the past we just relied on the transitive dependency of
@angular/bazelbeing hoisted, but the hoisting is not guaranteedif the lock file changes (e.g. when running
yarn upgrade). In general,dependencies we explicitly access, should be added as explicit dependencies.