fix(@angular-devkit/build-angular): several fixes for commonjs warnings #18081
Merged
filipesilva merged 2 commits intoangular:masterfrom Jul 1, 2020
alan-agius4:allowed-deps-pkg-name
Merged
fix(@angular-devkit/build-angular): several fixes for commonjs warnings #18081filipesilva merged 2 commits intoangular:masterfrom alan-agius4:allowed-deps-pkg-name
filipesilva merged 2 commits intoangular:masterfrom
alan-agius4:allowed-deps-pkg-name
Conversation
alan-agius4
added
the
target: patch
alan-agius4
changed the title
alan-agius4
changed the title
alan-agius4
added
target: patch
…t the package name With this change we add the functionality to also match an allowed dependency against a package name. The package name is retrieved from the rawRequest. Previously, users needed to add the request path which in some case might be a deep import. Ex: `zone.js/dist/zone-error`. With this change adding the package name example `zone.js` will suffice. Closes: #18058
…l locale data When using the `localize` option directly importing locale data from `@angular/common` is not needed because the Angular CLI will automatically include locale data. When not using the `localize` option, most likely users meant to import the global variant of the local data. See: https://angular.io/guide/i18n#import-global-variants-of-the-locale-data
clydin
approved these changes
Jul 1, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(@angular-devkit/build-angular): match allowed dependencies against the package name
With this change we add the functionality to also match an allowed dependency against a package name. The package name is retrieved from the rawRequest.
Previously, users needed to add the request path which in some case might be a deep import. Ex:
zone.js/dist/zone-error. With this change adding the package name examplezone.jswill suffice.Closes: #18058
fix(@angular-devkit/build-angular): show warning when using non global locale data
When using the
localizeoption directly importing locale data from@angular/commonis not needed because the Angular CLI will automatically include locale data. When not using thelocalizeoption, most likely users meant to import the global variant of the local data.See: https://angular.io/guide/i18n#import-global-variants-of-the-locale-data