Skip to content

feat(@schematics/angular): add tslint no-any and typedef rules when in strict mode #17834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
clydin merged 2 commits into from
Jun 1, 2020
Merged

feat(@schematics/angular): add tslint no-any and typedef rules when in strict mode #17834

clydin merged 2 commits into from
Jun 1, 2020

Conversation

@cyrilletuzi
Copy link
Contributor

@cyrilletuzi cyrilletuzi commented Jun 1, 2020

Fixes #17821

alan-agius4
alan-agius4 reviewed Jun 1, 2020
View reviewed changes
@cyrilletuzi cyrilletuzi mentioned this pull request Jun 1, 2020
Closed
1 task
alan-agius4
alan-agius4 approved these changes Jun 1, 2020
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

LGTM!

@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker labels Jun 1, 2020
@cyrilletuzi
Copy link
Contributor Author

cyrilletuzi commented Jun 1, 2020

@alan-agius4 Just one question: will it be included in v10.0?

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Jun 1, 2020

@cyrilletuzi, since it's a feature it will be available in 10.1. Since the v10 scope is closed.

@cyrilletuzi
Copy link
Contributor Author

cyrilletuzi commented Jun 1, 2020

@alan-agius4 Right, but as it do not affect current projects, and as it goes along with the other changes in v10 enhancing --strict option (new new prompt, full TS strict, stricter budgets, etc.), wouldn't it be nice to include it in v10.0 to promote this mode when Angular 10 stable is released (for example in the release blog post)?

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Jun 1, 2020
@alan-agius4
Copy link
Collaborator

alan-agius4 commented Jun 1, 2020

So we had a chat around this, and we decided to have it part of 10.0

IgorMinar
IgorMinar approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

We might want to document that in case you want to break out of type checking in case you need to monkey patch an object, etc, then you can you ts-ignore comment.

@clydin clydin merged commit f9da2d8 into angular:master Jun 1, 2020
@cyrilletuzi cyrilletuzi deleted the strictlint branch June 1, 2020 19:54
alan-agius4 added a commit to angular/universal that referenced this pull request Jun 10, 2020
@alan-agius4
fix(express-engine): make server.ts compliant with typedef tslint rule
4bb3837 
Related to: angular/angular-cli#17834
alan-agius4 added a commit to angular/universal that referenced this pull request Jun 10, 2020
@alan-agius4
fix(hapi-engine): make server.ts compliant with typedef tslint rule
a9e9ea6 
Related to: angular/angular-cli#17834
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 2, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

+1 more reviewer

@IgorMinar IgorMinar IgorMinar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enforce stricter types via lint when in strict mode

5 participants

@cyrilletuzi @alan-agius4 @IgorMinar @googlebot @clydin