Skip to content

build: use TS 3.6.4#15847

Merged
vikerman merged 5 commits intoangular:masterfrom
filipesilva:ts-3.6
Oct 16, 2019
Merged

build: use TS 3.6.4#15847
vikerman merged 5 commits intoangular:masterfrom
filipesilva:ts-3.6

Conversation

@filipesilva
Copy link
Copy Markdown
Contributor

@filipesilva filipesilva commented Oct 15, 2019 •
edited
Loading

Blocked on angular/angular#32946 being merged and released.

@filipesilva filipesilva mentioned this pull request Oct 15, 2019
Closed
14 tasks
alan-agius4
alan-agius4 reviewed Oct 16, 2019
View reviewed changes
Comment thread packages/ngtools/webpack/package.json Outdated
"peerDependencies": {
"@angular/compiler-cli": "^8.0.0-beta.0 || ^8.1.0-beta.0 || ^8.2.0-beta.0 || ^8.3.0-beta.0 || ^8.4.0-beta.0 || >=9.0.0-beta < 9",
"typescript": ">=3.4 < 3.6",
"typescript": ">=3.4 < 3.7",
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should update the peerDeps to only support Angular 9 and TypeScript 3.6?

Copy link
Copy Markdown
Contributor Author

@filipesilva filipesilva Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

alan-agius4
alan-agius4 reviewed Oct 16, 2019
View reviewed changes
Comment thread packages/angular_devkit/build_angular/package.json Outdated
"peerDependencies": {
"@angular/compiler-cli": "^8.0.0-beta.0 || ^8.1.0-beta.0 || ^8.2.0-beta.0 || ^8.3.0-beta.0 || ^8.4.0-beta.0 || >=9.0.0-beta < 9",
"typescript": ">=3.1 < 3.6"
"typescript": ">=3.1 < 3.7"
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 Oct 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should update the peerDeps to only support Angular 9 and TypeScript 3.6?

FW dropped support for previous TS versions angular/angular#32946

Copy link
Copy Markdown
Contributor Author

@filipesilva filipesilva Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@filipesilva filipesilva added target: major This PR is targeted for the next major release and removed state: blocked labels Oct 16, 2019
@filipesilva filipesilva marked this pull request as ready for review October 16, 2019 13:53
clydin
clydin reviewed Oct 16, 2019
View reviewed changes
Comment thread packages/angular_devkit/build_angular/package.json
"peerDependencies": {
"@angular/compiler-cli": "^8.0.0-beta.0 || ^8.1.0-beta.0 || ^8.2.0-beta.0 || ^8.3.0-beta.0 || ^8.4.0-beta.0 || >=9.0.0-beta < 9",
"typescript": ">=3.1 < 3.6"
"@angular/compiler-cli": ">=9.0.0-beta < 10",
Copy link
Copy Markdown
Member

@clydin clydin Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should track this so that it is changed to ^9.0.0 once the final release is out.

@filipesilva
fix(@angular-devkit/build-angular): roll angular app test back to VE
0a4dd9b 
This should really be using Ivy but was getting the error below on every second build.
`ERROR in Cannot read property 'incrementalState' of null`
filipesilva
filipesilva commented Oct 16, 2019
View reviewed changes
Comment thread tests/angular_devkit/build_webpack/angular-app/tsconfig.json
"enableIvy": true,
// TODO: debug this problem.
// This should really be true but was getting the error below on every second build.
// `ERROR in Cannot read property 'incrementalState' of null`
Copy link
Copy Markdown
Contributor Author

@filipesilva filipesilva Oct 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking it in #15857

Note: on master Ivy is disabled for this test too. This PR originally tried to enable it and then I rolled the change back so that this PR can go forward and the problem can be investigated separately.

alan-agius4
alan-agius4 approved these changes Oct 16, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikerman vikerman merged commit 7d3460d into angular:master Oct 16, 2019
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Nov 16, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@clydin clydin clydin left review comments

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees

No one assigned

Labels

target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@filipesilva @alan-agius4 @clydin @vikerman @googlebot