feat(change_detection): make INTERPOLATE_REGEXP customizable#7417
Merged
mhevery merged 1 commit intoangular:masterfrom May 26, 2016
Merged
feat(change_detection): make INTERPOLATE_REGEXP customizable#7417mhevery merged 1 commit intoangular:masterfrom
mhevery merged 1 commit intoangular:masterfrom
Conversation
lacolaco
force-pushed
the
laco-inject-interpolate-regexp
branch
3 times, most recently
from
061eaac to
32ce118
Compare
Contributor
There was a problem hiding this comment.
The compiler should not be configured via DI but rather via a new field on CompilerConfig (a new class that replaces ChangeDetectorConfig once you rebase).
Contributor
|
Need a rebase as well. |
tbosch
added
the
action: cleanup
lacolaco
force-pushed
the
laco-inject-interpolate-regexp
branch
from
32ce118 to
c9be63a
Compare
Contributor
Author
|
I've rebased but then new feature's tests were dropped. |
lacolaco
force-pushed
the
laco-inject-interpolate-regexp
branch
from
c9be63a to
a1de09c
Compare
Contributor
Author
|
New approach: new CompilerConfig(true, true, true, null, /<<([\s\S]*?)>>/g) |
3 tasks
lacolaco
force-pushed
the
laco-inject-interpolate-regexp
branch
from
a1de09c to
5276bf1
Compare
BREAKING CHANGES: `Parser` constructor required new parameter `config: CompilerConfig` as second argument.
lacolaco
force-pushed
the
laco-inject-interpolate-regexp
branch
from
5276bf1 to
5d13e48
Compare
vicb
added a commit
to vicb/angular
that referenced
this pull request
Jun 2, 2016
…ngular#7417)" This reverts commit c3fafa0. The symbols should be configured at the component level and not be global to the compiler.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
The pattern for interpolation is not able to modify.
INTERPOLATE_REGEXPis a variable and is referred inParserdirectly.Add new public api,
INTERPOLATE_REGEXP, which allows us customize interpolation regexp pattern. (for Python Jinja and more template languages).Similar api is in AngularJS as
$interpolateProvider.And
Parsertakes the pattern for interpolation from DI.Parserconstructor required new parameterinterpolateRegexpas second argument.Close Request: Compatible API to
$interpolateProvider.startSymbol,endSymbol#7305