Skip to content

fix(core): fixes a regression with animate.leave and reordering#67765

Merged
leonsenft merged 1 commit intoangular:mainfrom
thePunderWoman:animation-event-bug
Mar 19, 2026
Merged

fix(core): fixes a regression with animate.leave and reordering#67765
leonsenft merged 1 commit intoangular:mainfrom
thePunderWoman:animation-event-bug

Conversation

@thePunderWoman
Copy link
Copy Markdown
Contributor

This fixes a regression bug that resulted in reordered elements not getting properly removed from the DOM. Reused nodes were not being cleared out in this situation.

fixes: #67728

This fixes a regression bug that resulted in reordered elements not getting properly removed from the DOM. Reused nodes were not being cleared out in this situation.

fixes: angular#67728
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Mar 19, 2026
@ngbot ngbot bot added this to the Backlog milestone Mar 19, 2026
@thePunderWoman thePunderWoman added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 19, 2026
thePunderWoman added a commit to thePunderWoman/angular that referenced this pull request Mar 19, 2026
PATCH PR for angular#67765

This fixes a regression bug that resulted in reordered elements not getting properly removed from the DOM. Reused nodes were not being cleared out in this situation.

fixes: angular#67728
@thePunderWoman thePunderWoman removed the request for review from atscott March 19, 2026 22:30
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 19, 2026
@ngbot
Copy link
Copy Markdown

ngbot bot commented Mar 19, 2026

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@thePunderWoman thePunderWoman added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 19, 2026
@thePunderWoman
Copy link
Copy Markdown
Contributor Author

Caretaker note: The failing test in G3 is unrelated and previously failing.

@leonsenft leonsenft merged commit dfa149d into angular:main Mar 19, 2026
28 of 30 checks passed
@leonsenft
Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

leonsenft pushed a commit that referenced this pull request Mar 19, 2026
PATCH PR for #67765

This fixes a regression bug that resulted in reordered elements not getting properly removed from the DOM. Reused nodes were not being cleared out in this situation.

fixes: #67728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular does not remove component from the DOM with (animate.leave) hook after list reordering since 21.2

3 participants