fix(core): avoid leaking view data in animations#66256
Merged
kirjs merged 1 commit intoangular:mainfrom Jan 7, 2026
Merged
Conversation
The animations code currently tracks which views have running leave animations by adding them to a `Set`. This can leak memory if we don't clean something up on time. These changes switch to tracking the views by their ID which doesn't risk retaining the view. Fixes angular#66255.
crisbeto
added
action: review
thePunderWoman
approved these changes
Jan 5, 2026
Contributor
thePunderWoman
left a comment
thePunderWoman
left a comment
There was a problem hiding this comment.
Ah good idea! Thanks for this.
crisbeto
added
action: merge
Contributor
|
@crisbeto could you backport this fix to 20.x branch? |
Member
|
Per our API policy, we only backport security fixes to versions that are in LTS. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The animations code currently tracks which views have running leave animations by adding them to a
Set. This can leak memory if we don't clean something up on time.These changes switch to tracking the views by their ID which doesn't risk retaining the view.
Fixes #66255.