fix(forms): allow resetting with empty string #65950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
force-pushed
the
forms-node-reset
branch
2 times, most recently
from
438d548 to
07fff77
Compare
JeanMeche
force-pushed
the
forms-node-reset
branch
2 times, most recently
from
64bdb74 to
b458850
Compare
|
@JeanMeche Should there also be a test for "can reset with false"? |
Both empty string and null values should be accepted when resetting fixes angular#65949
Member
Author
|
@tylerlittle I like that this is exactly what copilot suggested once I started adding a new test case 😄 |
JeanMeche
force-pushed
the
forms-node-reset
branch
from
b458850 to
589881a
Compare
mmalerba
approved these changes
Dec 10, 2025
JeanMeche
added
action: merge
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both empty string and null values should be accepted when resetting
fixes #65949