fix(core): unable to inject viewProviders when host directive with providers is present #65778
+101
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
…oviders is present When registering providers, the DI system assumes that `viewProviders` are registered before plain `providers`. This was reinforced by components always being first in the array of directive matches, only one component being allowed per node and the fact that only components can have `viewProviders`. This breaks down if there are host directives with `providers` on the component, because they'll execute earlier, throwing off the order of operations. These changes fix the issue by separating out the resolvers for `viewProviders` and plain `providers` and explicitly running the component's `viewProviders` resolver before any others. This also has the benefit of not attempting to resolve `viewProviders` for directives which are guaranteed not to have them. Fixes angular#65724.
crisbeto
force-pushed
the
view-providers-host-dirs
branch
from
220b6c9 to
fc6fbea
Compare
crisbeto
added
the
action: global presubmit
Member
Author
crisbeto
removed
the
action: global presubmit
crisbeto
added
action: merge
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering providers, the DI system assumes that
viewProvidersare registered before plainproviders. This was reinforced by components always being first in the array of directive matches, only one component being allowed per node and the fact that only components can haveviewProviders.This breaks down if there are host directives with
providerson the component, because they'll execute earlier, throwing off the order of operations.These changes fix the issue by separating out the resolvers for
viewProvidersand plainprovidersand explicitly running the component'sviewProvidersresolver before any others. This also has the benefit of not attempting to resolveviewProvidersfor directives which are guaranteed not to have them.Fixes #65724.