fix(core): run animation queue in application root injector context #65634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePunderWoman
added
action: review
thePunderWoman
changed the title
JoostK
reviewed
Nov 25, 2025
thePunderWoman
force-pushed
the
animation-test
branch
4 times, most recently
from
3a3a22c to
03c502d
Compare
JoostK
approved these changes
Nov 25, 2025
AndrewKushnir
approved these changes
Nov 25, 2025
AndrewKushnir
removed
the
action: review
thePunderWoman
force-pushed
the
animation-test
branch
3 times, most recently
from
deab056 to
3820fce
Compare
In the case that a component injector is destroyed before the animation queue runs, the animation queue would fail to run because it was using a destroyed injector. This commit changes the animation queue to run in the context of the EnvironmentInjector, which is not destroyed until the app is destroyed. fixes: angular#65628
thePunderWoman
force-pushed
the
animation-test
branch
from
3820fce to
bee6e4f
Compare
thePunderWoman
added
the
action: merge
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that a component injector is destroyed before the animation queue runs, the animation queue would fail to run because it was using a destroyed injector. This commit changes the animation queue to run in the context of the Application root injector, which is not destroyed until the app is destroyed.
fixes: #65628