Skip to content

fix(forms): support dynamic [field] bindings #65599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leonsenft wants to merge 4 commits into from
Closed

fix(forms): support dynamic [field] bindings #65599

leonsenft wants to merge 4 commits into from

Conversation

@leonsenft
Copy link
Contributor

@leonsenft leonsenft commented Nov 24, 2025

Support binding a Field directive to a component created dynamically with createComponent().

Fix #64632

@leonsenft leonsenft requested a review from crisbeto November 24, 2025 18:51
@leonsenft leonsenft added area: forms target: patch This PR is targeted for the next patch release forms: signals labels Nov 24, 2025
@ngbot ngbot bot modified the milestone: Backlog Nov 24, 2025
@leonsenft leonsenft requested a review from mmalerba November 24, 2025 20:10
crisbeto
crisbeto approved these changes Nov 25, 2025
View reviewed changes
mmalerba
mmalerba approved these changes Nov 25, 2025
View reviewed changes
@leonsenft leonsenft force-pushed the signal-forms-dynamic-field-binding branch from bcb90e3 to 94146bb Compare November 26, 2025 17:15
@angular-robot angular-robot bot requested a review from crisbeto November 26, 2025 17:15
@angular-robot angular-robot bot added area: performance Issues related to performance area: core Issues related to the framework runtime labels Nov 26, 2025
@leonsenft leonsenft requested a review from mmalerba November 26, 2025 17:17
mmalerba
mmalerba approved these changes Nov 26, 2025
View reviewed changes
@leonsenft leonsenft force-pushed the signal-forms-dynamic-field-binding branch from 94146bb to 0558521 Compare November 26, 2025 17:33
@leonsenft
fix(forms): support dynamic [field] bindings
ec45645 
Support binding a `Field` directive to a component created dynamically
with `createComponent()`.

Fix angular#64632
@leonsenft
perf(core): tree shake unused dynamic [field] binding instructions
a115139 
Move the instructions used to dynamically bind a `Field` directive to a
form control onto the `Field` itself. This way the instructions are only
retained if the app uses the `Field` directive.
@leonsenft
fixup! perf(core): tree shake unused dynamic [field] binding instru…
a13f21f 
…ctions
@leonsenft leonsenft force-pushed the signal-forms-dynamic-field-binding branch from 0558521 to a13f21f Compare December 1, 2025 23:02
@pullapprove pullapprove bot requested a review from JeanMeche December 1, 2025 23:03
@leonsenft leonsenft removed the request for review from JeanMeche December 1, 2025 23:04
@pullapprove pullapprove bot requested a review from JeanMeche December 1, 2025 23:04
JeanMeche
JeanMeche reviewed Dec 1, 2025
View reviewed changes
@pullapprove pullapprove bot requested a review from JeanMeche December 1, 2025 23:12
JeanMeche
JeanMeche approved these changes Dec 1, 2025
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

(I don't want to be blocking on this with my previous comment)

@leonsenft leonsenft removed the request for review from crisbeto December 2, 2025 21:25
@leonsenft leonsenft added the action: merge The PR is ready for merge by the caretaker label Dec 2, 2025
@leonsenft leonsenft mentioned this pull request Dec 2, 2025
Closed
@leonsenft
Copy link
Contributor Author

leonsenft commented Dec 2, 2025 •
edited
Loading

note for caretaker: TAP failure is an existing failure.

Finally passing.

@leonsenft leonsenft added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Dec 2, 2025
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Dec 3, 2025

This PR was merged into the repository. The changes were merged into the following branches:

pkozlowski-opensource pushed a commit that referenced this pull request Dec 3, 2025
@leonsenft @pkozlowski-opensource
perf(core): tree shake unused dynamic [field] binding instructions (#…
e6d5632 
…65599)

Move the instructions used to dynamically bind a `Field` directive to a
form control onto the `Field` itself. This way the instructions are only
retained if the app uses the `Field` directive.

PR Close #65599
pkozlowski-opensource pushed a commit that referenced this pull request Dec 3, 2025
@leonsenft @pkozlowski-opensource
fix(forms): support dynamic [field] bindings (#65599)
a5dbd4b 
Support binding a `Field` directive to a component created dynamically
with `createComponent()`.

Fix #64632

PR Close #65599
pkozlowski-opensource pushed a commit that referenced this pull request Dec 3, 2025
@leonsenft @pkozlowski-opensource
perf(core): tree shake unused dynamic [field] binding instructions (#…
609699a 
…65599)

Move the instructions used to dynamically bind a `Field` directive to a
form control onto the `Field` itself. This way the instructions are only
retained if the app uses the `Field` directive.

PR Close #65599
@leonsenft leonsenft deleted the signal-forms-dynamic-field-binding branch December 5, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: forms area: performance Issues related to performance forms: signals target: patch This PR is targeted for the next patch release

Projects

Experimental Signal Forms
Status: Done

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Signal forms: Creating custom fields dynamically with Field directive doesn't attach status and value to field

5 participants

@leonsenft @pkozlowski-opensource @JeanMeche @crisbeto @mmalerba