fix(zone.js): correctly bundle zone-patch-rxjs#55826
Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Closed
fix(zone.js): correctly bundle zone-patch-rxjs#55826alan-agius4 wants to merge 1 commit intoangular:mainfrom
zone-patch-rxjs#55826alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
alan-agius4
added
the
action: review
alan-agius4
added
area: zones
alan-agius4
force-pushed
the
rxjs-zone.js
branch
2 times, most recently
from
ab8d1d0 to
75419c4
Compare
angular#53443 caused the a local `rxjs` file to be imported from an entry-point which caused this to be excluded from being bundled due to the name matching `rxjs`. Closes angular#55825
alxhub
approved these changes
May 16, 2024
alxhub
approved these changes
May 16, 2024
Member
alxhub
left a comment
alxhub
left a comment
There was a problem hiding this comment.
Reviewed-for: global-approvers
alan-agius4
added
action: merge
alan-agius4
added
target: rc
Contributor
|
This PR was merged into the repository by commit 20a530a. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#53443 caused the local
rxjsfile to be imported from an entry-point which caused this to be excluded from being bundled due to the name matchingrxjs.Closes #55825