refactor(core): Update method of grabbing native setTimeout and rAF#55092
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): Update method of grabbing native setTimeout and rAF#55092atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
atscott
added
area: core
atscott
force-pushed
the
unpatchedthing
branch
2 times, most recently
from
c69033f to
02fd7ea
Compare
As mentioned in angular#54600 (comment) a more effective way of getting the unpatched version of a zone-patched API is to grab it from global[Zone.__symbol__('apiname')].
Contributor
|
This PR was merged into the repository by commit 58942db. |
atscott
added a commit
to atscott/angular
that referenced
this pull request
Apr 5, 2024
Now that angular#55092 has merged, we now consistently get the `setTimeout` and `rAF` implementations that are not patched by zone. There's no longer a need to run them in the root zone.
atscott
added a commit
that referenced
this pull request
Apr 8, 2024
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 11, 2024
…lar#55230) Now that angular#55092 has merged, we now consistently get the `setTimeout` and `rAF` implementations that are not patched by zone. There's no longer a need to run them in the root zone. PR Close angular#55230
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #54600 (comment) a more effective way of getting the unpatched version of a zone-patched API is to grab it from global[Zone.symbol('apiname')].