fix(zone.js): should not clear onhandler when remove capture listener#54602
Closed
JiaLiPassion wants to merge 1 commit intoangular:mainfrom
Closed
fix(zone.js): should not clear onhandler when remove capture listener#54602JiaLiPassion wants to merge 1 commit intoangular:mainfrom
JiaLiPassion wants to merge 1 commit intoangular:mainfrom
Conversation
maxpatiiuk
approved these changes
Feb 25, 2024
maxpatiiuk
left a comment
maxpatiiuk
left a comment
There was a problem hiding this comment.
Thanks for fixing this! The code and test looks good 💎
AndrewKushnir
added
action: review
Close angular#54581 Should not clear `onHandler` when remove capture event listeners.
JiaLiPassion
force-pushed
the
on-event-remove-capture
branch
from
7fbd86f to
9e2900b
Compare
AndrewKushnir
approved these changes
Feb 27, 2024
AndrewKushnir
added
action: presubmit
|
Is there an ETA for this? Thanks |
Contributor
Contributor
|
Caretaker note: TGP is "green", but it'd still be great to merge and sync this change separately. |
AndrewKushnir
added
action: merge
Contributor
|
I'm going to hold this one until Monday, and sync it at the beginning of the week on its own. |
Contributor
|
This PR was merged into the repository by commit e44b077. |
dylhunn
pushed a commit
that referenced
this pull request
Mar 27, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #54581
Should not clear
onHandlerwhen remove capture event listeners.