Skip to content

fix(zone.js): patch fs.realpath.native as macrotask#54208

Closed
arturovt wants to merge 1 commit intoangular:mainfrom
arturovt:fix/45546
Closed

fix(zone.js): patch fs.realpath.native as macrotask#54208
arturovt wants to merge 1 commit intoangular:mainfrom
arturovt:fix/45546

Conversation

@arturovt
Copy link
Copy Markdown
Contributor

@arturovt arturovt commented Feb 2, 2024

This commit updates the implementation of the zone.js fs patch to restore the implementation of realpath.native and patches it as a macrotask, along with other functions of the fs package. This is the only nested function that must be patched.

Closes: #45546

This commit updates the implementation of the zone.js `fs` patch to
restore the implementation of `realpath.native` and patches it as a macrotask,
along with other functions of the `fs` package. This is the only nested function
that must be patched.

Closes: angular#45546
@arturovt arturovt marked this pull request as ready for review February 2, 2024 08:57
@pullapprove pullapprove Bot requested a review from JiaLiPassion February 2, 2024 08:57
@jessicajaniuk jessicajaniuk added the area: zones Issues related to zone.js label Feb 2, 2024
@ngbot ngbot Bot added this to the Backlog milestone Feb 2, 2024
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 2, 2024
Copy link
Copy Markdown
Contributor

@JiaLiPassion JiaLiPassion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 6, 2024
jessicajaniuk pushed a commit that referenced this pull request Feb 6, 2024
This commit updates the implementation of the zone.js `fs` patch to
restore the implementation of `realpath.native` and patches it as a macrotask,
along with other functions of the `fs` package. This is the only nested function
that must be patched.

Closes: #45546

PR Close #54208
@jessicajaniuk
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 19fae76.

@arturovt arturovt deleted the fix/45546 branch February 6, 2024 16:06
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zone.js/node breaks for fs.realpath.native and fs.realpathSync.native

4 participants