build: ensure zone.js typing test is hermetic#54048
Closed
devversion wants to merge 1 commit intoangular:mainfrom
Closed
build: ensure zone.js typing test is hermetic#54048devversion wants to merge 1 commit intoangular:mainfrom
devversion wants to merge 1 commit intoangular:mainfrom
Conversation
Currently the ZoneJS typing tests executes outside of Bazel, as a legacy artifact of the monorepo merging (as it seems - not ideal at all). Looks like this test relies on its own node modules, that were NOT locked using a yarn lock file. This commit adds one, and specifically locks it to a `@types/node` version that does not include the most recent patch release (which seemingly introduced a breaking change) that causes issues with TypeScript's lib checking. Whenever we perform lock file maintenance in the future, we have the following options: - Consider disabling lib checking via `skipLibCheck` for this test. This may be acceptable. - Continue locking the node version, - Waiting for chokidar to comply with the new signature - Waiting for the breaking change to be rolled back. Culprit change: DefinitelyTyped/DefinitelyTyped#68300
angular-robot
bot
added
the
area: build & ci
devversion
added
action: review
pkozlowski-opensource
approved these changes
Jan 24, 2024
pkozlowski-opensource
added
action: merge
Member
|
caretaker note: this is a fix for the failing build on |
Member
|
This PR was merged into the repository by commit 25f91e3. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jan 24, 2024
Currently the ZoneJS typing tests executes outside of Bazel, as a legacy artifact of the monorepo merging (as it seems - not ideal at all). Looks like this test relies on its own node modules, that were NOT locked using a yarn lock file. This commit adds one, and specifically locks it to a `@types/node` version that does not include the most recent patch release (which seemingly introduced a breaking change) that causes issues with TypeScript's lib checking. Whenever we perform lock file maintenance in the future, we have the following options: - Consider disabling lib checking via `skipLibCheck` for this test. This may be acceptable. - Continue locking the node version, - Waiting for chokidar to comply with the new signature - Waiting for the breaking change to be rolled back. Culprit change: DefinitelyTyped/DefinitelyTyped#68300 PR Close #54048
pkozlowski-opensource
pushed a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Jan 24, 2024
Currently the ZoneJS typing tests executes outside of Bazel, as a legacy artifact of the monorepo merging (as it seems - not ideal at all). Looks like this test relies on its own node modules, that were NOT locked using a yarn lock file. This commit adds one, and specifically locks it to a `@types/node` version that does not include the most recent patch release (which seemingly introduced a breaking change) that causes issues with TypeScript's lib checking. Whenever we perform lock file maintenance in the future, we have the following options: - Consider disabling lib checking via `skipLibCheck` for this test. This may be acceptable. - Continue locking the node version, - Waiting for chokidar to comply with the new signature - Waiting for the breaking change to be rolled back. Culprit change: DefinitelyTyped/DefinitelyTyped#68300 PR Close angular#54048
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
Currently the ZoneJS typing tests executes outside of Bazel, as a legacy artifact of the monorepo merging (as it seems - not ideal at all). Looks like this test relies on its own node modules, that were NOT locked using a yarn lock file. This commit adds one, and specifically locks it to a `@types/node` version that does not include the most recent patch release (which seemingly introduced a breaking change) that causes issues with TypeScript's lib checking. Whenever we perform lock file maintenance in the future, we have the following options: - Consider disabling lib checking via `skipLibCheck` for this test. This may be acceptable. - Continue locking the node version, - Waiting for chokidar to comply with the new signature - Waiting for the breaking change to be rolled back. Culprit change: DefinitelyTyped/DefinitelyTyped#68300 PR Close angular#54048
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
Currently the ZoneJS typing tests executes outside of Bazel, as a legacy artifact of the monorepo merging (as it seems - not ideal at all). Looks like this test relies on its own node modules, that were NOT locked using a yarn lock file. This commit adds one, and specifically locks it to a `@types/node` version that does not include the most recent patch release (which seemingly introduced a breaking change) that causes issues with TypeScript's lib checking. Whenever we perform lock file maintenance in the future, we have the following options: - Consider disabling lib checking via `skipLibCheck` for this test. This may be acceptable. - Continue locking the node version, - Waiting for chokidar to comply with the new signature - Waiting for the breaking change to be rolled back. Culprit change: DefinitelyTyped/DefinitelyTyped#68300 PR Close angular#54048
nikvarma
pushed a commit
to nikvarma/angular
that referenced
this pull request
Jan 31, 2024
Currently the ZoneJS typing tests executes outside of Bazel, as a legacy artifact of the monorepo merging (as it seems - not ideal at all). Looks like this test relies on its own node modules, that were NOT locked using a yarn lock file. This commit adds one, and specifically locks it to a `@types/node` version that does not include the most recent patch release (which seemingly introduced a breaking change) that causes issues with TypeScript's lib checking. Whenever we perform lock file maintenance in the future, we have the following options: - Consider disabling lib checking via `skipLibCheck` for this test. This may be acceptable. - Continue locking the node version, - Waiting for chokidar to comply with the new signature - Waiting for the breaking change to be rolled back. Culprit change: DefinitelyTyped/DefinitelyTyped#68300 PR Close angular#54048
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the ZoneJS typing tests executes outside of Bazel, as a legacy artifact of the monorepo merging (as it seems - not ideal at all).
Looks like this test relies on its own node modules, that were NOT locked using a yarn lock file. This commit adds one, and specifically locks it to a
@types/nodeversion that does not include the most recent patch release (which seemingly introduced a breaking change) that causes issues with TypeScript's lib checking.Whenever we perform lock file maintenance in the future, we have the following options:
skipLibCheckfor this test. This may be acceptable.Culprit change:
DefinitelyTyped/DefinitelyTyped#68300
Note: Also improving the CI code so that it can be run locally more easily (i.e. by following steps of CI for these legacy tests.. running these properly is a different story)