Zonejs package exports fixes#51737
Closed
alan-agius4 wants to merge 2 commits intoangular:mainfrom
Closed
Conversation
`typings` is not valid for TypeScript. See: https://www.typescriptlang.org/docs/handbook/esm-node.html for more information.
alan-agius4
force-pushed
the
zonejs-package-exports-fix
branch
from
556eccd to
6b40d49
Compare
alan-agius4
added
action: review
alan-agius4
added
the
target: minor
`jest-preset-angular` imports `zone.js` using deep imports. This commit temporary allow this until the correct entry-points are used upstream. See: thymikee/jest-preset-angular#2162
alan-agius4
force-pushed
the
zonejs-package-exports-fix
branch
from
772ead4 to
142f695
Compare
Contributor
|
just to be clear, that won't solve the issue of jest-preset-angular on its own since the umd bundle will still be named |
alan-agius4
added
action: merge
Contributor
|
This PR was merged into the repository by commit e86d6db. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Sep 12, 2023
`jest-preset-angular` imports `zone.js` using deep imports. This commit temporary allow this until the correct entry-points are used upstream. See: thymikee/jest-preset-angular#2162 PR Close #51737
Contributor
|
@alan-agius4 @JiaLiPassion do we want to cut another Zone.js release to push those changes to NPM? |
Contributor
Author
|
Yes @AndrewKushnir |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…#51737) `typings` is not valid for TypeScript. See: https://www.typescriptlang.org/docs/handbook/esm-node.html for more information. PR Close angular#51737
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
`jest-preset-angular` imports `zone.js` using deep imports. This commit temporary allow this until the correct entry-points are used upstream. See: thymikee/jest-preset-angular#2162 PR Close angular#51737
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(zone.js): temporary allow deep imports
jest-preset-angularimportszone.jsusing deep imports. This commit temporary allow this until the correct entry-points are used upstream. See: thymikee/jest-preset-angular#2162fix(zone.js): rename
typingsconditional export totypestypingsis not valid for TypeScript. See: https://www.typescriptlang.org/docs/handbook/esm-node.html for more information.