fix(zone.js): add conditional exports to zone.js package#51652
Closed
alan-agius4 wants to merge 4 commits intoangular:mainfrom
Closed
fix(zone.js): add conditional exports to zone.js package#51652alan-agius4 wants to merge 4 commits intoangular:mainfrom
alan-agius4 wants to merge 4 commits intoangular:mainfrom
Conversation
alan-agius4
force-pushed
the
zone-js-add-conditional-exports
branch
from
fda742a to
f5d1915
Compare
alan-agius4
added
the
target: major
alan-agius4
force-pushed
the
zone-js-add-conditional-exports
branch
9 times, most recently
from
b25b6ca to
1ed0b00
Compare
angular-robot
Bot
added
the
area: build & ci
alan-agius4
force-pushed
the
zone-js-add-conditional-exports
branch
5 times, most recently
from
1097ede to
ea5b7b7
Compare
alan-agius4
added
the
action: review
pullapprove
Bot
requested review from
AndrewKushnir,
JiaLiPassion and
devversion
clydin
reviewed
Sep 5, 2023
clydin
reviewed
Sep 5, 2023
This is needed to better support native ESM modules and avoid the otherwise necessary deep imports like `zone.js/fesm2015/zone-node.js` due to disallowed directory imports.
alan-agius4
force-pushed
the
zone-js-add-conditional-exports
branch
from
ea5b7b7 to
2e49034
Compare
angular-robot
Bot
removed
the
area: build & ci
This commit update the lock file to force a new `node_modules` cache as this causes the patch to fail due to GitHub caching and at present, there is also no way to provide a key to invalidate the cache.
angular-robot
Bot
added
the
area: build & ci
devversion
approved these changes
Sep 6, 2023
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
Nice, only thing that will be a little slower is having to build the full zone npm package for benchmarks- but I think that is reasonable
AndrewKushnir
approved these changes
Sep 6, 2023
alan-agius4
added
action: merge
Contributor
|
This PR was merged into the repository by commit cfe2f1d. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Sep 6, 2023
This commit update the lock file to force a new `node_modules` cache as this causes the patch to fail due to GitHub caching and at present, there is also no way to provide a key to invalidate the cache. PR Close #51652
AviVahl
reviewed
Sep 11, 2023
| "default": "./package.json" | ||
| }, | ||
| ".": { | ||
| "typings": "./zone.d.ts", |
There was a problem hiding this comment.
this must say "types" for typescript to pick it up when project uses "moduleResolution" that respects "exports" (e.g. moduleResolution": "bundler").
Contributor
Author
There was a problem hiding this comment.
Thanks for bringing this up. Here's a fix #51737
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This is needed to better support native ESM modules and avoid the otherwise necessary deep imports like `zone.js/fesm2015/zone-node.js` due to disallowed directory imports. PR Close angular#51652
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This commit update the lock file to force a new `node_modules` cache as this causes the patch to fail due to GitHub caching and at present, there is also no way to provide a key to invalidate the cache. PR Close angular#51652
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to better support native ESM modules and avoid the otherwise necessary deep imports like
zone.js/fesm2015/zone-node.jsdue to disallowed directory imports.