feat(router): Add feature to support the View Transitions API by atscott · Pull Request #51314 · angular/angular

atscott · 2023-08-09T23:05:04Z

The View Transitions API enables easy animations when transitioning between different DOM states. This commit adds an opt-in feature to the Router which runs the component activation and deactivation logic in the document.startViewTransition callback. If the browser does not support this API, route activation and deactivation will happen synchronously.

resolves #49401

atscott · 2023-08-11T20:07:24Z

Updating risk to medium since the view transition adds a delay to where code was synchronous before. Exact timings in the Router have historically been fragile. It is technically possible to keep the code synchronous if the feature is not enabled, but avoiding "sometimes synchronous, sometimes asynchronous" branch in the code would be ideal.

atscott · 2023-08-29T21:08:19Z

Removing risk label since I ended up going with the sometimes sync, sometimes async behavior so that the default behavior is unchanged.

atscott · 2023-08-30T16:07:06Z

TGP shows no failures for the current approach. I ran a quick test to enable view transitions unconditionally and it appears that test failures are generally due to ZoneJS and the fact that it doesn't patch the startViewTransition API so the fakeAsync with flush and tick doesn't work. However, tests can instead use async/await along with the RouterTestingHarness to resolve these failures.

jessicajaniuk

reviewed-for: public-api

AndrewKushnir

Looks great, just a few minor comments.

AndrewKushnir · 2023-09-01T16:37:37Z

I'm not sure this is reflected on AIO, should we use @developerPreview instead?

I'm not sure either but @jelbourn did mention this tag and we believe it's more appropriate given the state of the view transition API in general.

@jelbourn It does appear that the @experimental tag doesn't show up on AIO (https://ng-dev-previews-fw--pr-angular-angular-51314-y5diongs.web.app/api/router/withViewTransitions)

AndrewKushnir

Reviewed-for: public-api

github-actions · 2023-09-05T21:05:00Z

Deployed aio for b3a240f to: https://ng-dev-previews-fw--pr-angular-angular-51314-y5diongs.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

The View Transitions API enables easy animations when transitioning between different DOM states. This commit adds an opt-in feature to the Router which runs the component activation and deactivation logic in the document.startViewTransition callback. If the browser does not support this API, route activation and deactivation will happen synchronously. resolves angular#49401

AndrewKushnir · 2023-09-11T17:36:13Z

This PR was merged into the repository by commit 73e4bf2.

angular-automatic-lock-bot · 2023-10-12T00:07:31Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…r#51314) The View Transitions API enables easy animations when transitioning between different DOM states. This commit adds an opt-in feature to the Router which runs the component activation and deactivation logic in the document.startViewTransition callback. If the browser does not support this API, route activation and deactivation will happen synchronously. resolves angular#49401 PR Close angular#51314

atscott added the area: router label Aug 9, 2023

ngbot Bot added this to the Backlog milestone Aug 9, 2023

angular-robot Bot added the detected: feature PR contains a feature commit label Aug 9, 2023

atscott force-pushed the viewtransitionrouter branch 3 times, most recently from 82c9144 to 68c20e5 Compare August 11, 2023 20:05

atscott added the risk: medium label Aug 11, 2023

atscott added the action: global presubmit The PR is in need of a google3 global presubmit label Aug 11, 2023

ajafff reviewed Aug 14, 2023

View reviewed changes

Comment thread packages/router/src/operators/activate_routes.ts Outdated

Comment thread packages/router/src/operators/activate_routes.ts Outdated

Comment thread packages/router/src/operators/activate_routes.ts Outdated

Comment thread packages/router/src/router_module.ts Outdated

atscott force-pushed the viewtransitionrouter branch 4 times, most recently from 4c36be8 to e813133 Compare August 15, 2023 23:17

devversion force-pushed the viewtransitionrouter branch from 1293543 to 1b9bc6e Compare August 17, 2023 12:00

atscott force-pushed the viewtransitionrouter branch 5 times, most recently from bf34e47 to f275113 Compare August 28, 2023 15:51

atscott removed the risk: medium label Aug 29, 2023

atscott force-pushed the viewtransitionrouter branch 2 times, most recently from e071790 to 0c58b90 Compare August 29, 2023 21:12

atscott added target: minor This PR is targeted for the next minor release and removed action: global presubmit The PR is in need of a google3 global presubmit labels Aug 30, 2023

atscott force-pushed the viewtransitionrouter branch 2 times, most recently from 8927fbe to 009b5e3 Compare August 30, 2023 21:25

atscott marked this pull request as ready for review August 30, 2023 22:26

pullapprove Bot requested review from alxhub, jessicajaniuk and pkozlowski-opensource September 1, 2023 12:16

jessicajaniuk approved these changes Sep 1, 2023

View reviewed changes

pullapprove Bot requested a review from AndrewKushnir September 1, 2023 14:50

AndrewKushnir approved these changes Sep 1, 2023

View reviewed changes

pullapprove Bot requested a review from AndrewKushnir September 1, 2023 16:53

AndrewKushnir approved these changes Sep 1, 2023

View reviewed changes

atscott added the aio: preview label Sep 5, 2023

atscott force-pushed the viewtransitionrouter branch 3 times, most recently from 5014f17 to e8b5d0b Compare September 5, 2023 21:00

atscott requested a review from AndrewKushnir September 5, 2023 21:07

AndrewKushnir approved these changes Sep 7, 2023

View reviewed changes

atscott force-pushed the viewtransitionrouter branch 2 times, most recently from b822a0e to c92bcac Compare September 8, 2023 19:34

fixup! feat(router): Add feature to support the View Transitions API

b3a240f

atscott force-pushed the viewtransitionrouter branch from c92bcac to b3a240f Compare September 8, 2023 22:26

atscott added the action: merge The PR is ready for merge by the caretaker label Sep 11, 2023

atscott removed request for alxhub and pkozlowski-opensource September 11, 2023 17:33

AndrewKushnir closed this in 73e4bf2 Sep 11, 2023

sp90 mentioned this pull request Sep 18, 2023

Add support for View Transition API in Router #49401

Closed

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 12, 2023

Conversation

atscott commented Aug 9, 2023

Uh oh!

atscott commented Aug 11, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atscott commented Aug 29, 2023

Uh oh!

atscott commented Aug 30, 2023

Uh oh!

jessicajaniuk left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

atscott Sep 5, 2023

Choose a reason for hiding this comment

Uh oh!

atscott Sep 5, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndrewKushnir commented Sep 11, 2023

Uh oh!

angular-automatic-lock-bot Bot commented Oct 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Sep 5, 2023 •

edited

Loading