Skip to content

refactor: standardize doctype declaration to <!DOCTYPE html> #51052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ptu14 wants to merge 1 commit into from
Closed

refactor: standardize doctype declaration to <!DOCTYPE html> #51052

ptu14 wants to merge 1 commit into from

Conversation

@ptu14
Copy link
Contributor

@ptu14 ptu14 commented Jul 15, 2023 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

Currently, the Angular codebase contains different variations of the DOCTYPE declaration including <!doctype html>, <!DOCTYPE html> and <!DOCTYPE HTML>. Though these are all technically correct as the DOCTYPE is case-insensitive, they lead to inconsistency in the codebase.

What is the new behavior?

This PR proposes to standardize the DOCTYPE declaration across the codebase to , as recommended by the official HTML Living Standard documentation by WHATWG (https://html.spec.whatwg.org/multipage/syntax.html#the-doctype). It helps to present the codebase in a more standardized and aligned way with the industry best practices.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Although this may seem like a minor detail, the standardization of these declarations adds to the overall quality and consistency of the project. This change was implemented using a find-and-replace command (cmd + R), so feel free to make any further changes, or alter the target merge branch if necessary.

I kindly request you to consider this PR for merging.

Thank you for your time and consideration.

Best Regards,
Mateusz

@google-cla
Copy link

google-cla bot commented Jul 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ptu14 ptu14 force-pushed the refactor/doctype-standardization branch 2 times, most recently from e4f6afb to e29958a Compare July 15, 2023 16:12
@ngbot ngbot bot added this to the Backlog milestone Jul 17, 2023
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 17, 2023
@ptu14 ptu14 force-pushed the refactor/doctype-standardization branch from e29958a to e489f62 Compare July 17, 2023 15:04
@ngbot ngbot bot removed this from the Backlog milestone Jul 17, 2023
@ngbot ngbot bot added this to the Backlog milestone Jul 17, 2023
@jessicajaniuk
Copy link
Contributor

jessicajaniuk commented Jul 17, 2023

@ptu14 Looks like this needs a rebase.

@ngbot ngbot bot modified the milestone: Backlog Jul 17, 2023
@ptu14 ptu14 force-pushed the refactor/doctype-standardization branch 3 times, most recently from 40c0baa to b5e7fd2 Compare July 17, 2023 17:14
@ptu14
Copy link
Contributor Author

ptu14 commented Jul 17, 2023

@ptu14 Looks like this needs a rebase.

done

@ngbot ngbot bot added this to the Backlog milestone Jul 17, 2023
@JeanMeche
Copy link
Member

JeanMeche commented Jan 31, 2024

Hi, could you rebase it again ? thx !

@ptu14 ptu14 force-pushed the refactor/doctype-standardization branch from b5e7fd2 to 4abd791 Compare January 31, 2024 20:55
@pullapprove pullapprove bot requested a review from josephperrott January 31, 2024 20:55
@ptu14
refactor: standardize doctype declaration to <!DOCTYPE html>
ccbf97f 
This commit standardizes the doctype declaration across all HTML files in the project to use `<!DOCTYPE html>`
@ptu14 ptu14 force-pushed the refactor/doctype-standardization branch from 4abd791 to ccbf97f Compare January 31, 2024 20:57
@ptu14
Copy link
Contributor Author

ptu14 commented Jan 31, 2024

Hi, could you rebase it again ? thx !

sure, a lot of DOCTYPE have been added since then 😅

alxhub
alxhub approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: global-approvers

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 1, 2024
jessicajaniuk pushed a commit that referenced this pull request Feb 1, 2024
@ptu14 @thePunderWoman
refactor: standardize doctype declaration to <!DOCTYPE html> (#51052)
52a31d0 
This commit standardizes the doctype declaration across all HTML files in the project to use `<!DOCTYPE html>`

PR Close #51052
@jessicajaniuk
Copy link
Contributor

jessicajaniuk commented Feb 1, 2024

This PR was merged into the repository by commit de777af.

@JeanMeche
Copy link
Member

JeanMeche commented Mar 2, 2024

Adding a note, as we're moving to prettier we're going to encounter some issues with it.
Per #prettier/prettier#6502 & prettier/prettier#7391 prettier does format DOCTYPE as doctype.

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 2, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub approved these changes

@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir

@crisbeto crisbeto Awaiting requested review from crisbeto

@dylhunn dylhunn Awaiting requested review from dylhunn

@JiaLiPassion JiaLiPassion Awaiting requested review from JiaLiPassion

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@ptu14 @jessicajaniuk @JeanMeche @alxhub