Skip to content

fix(zone.js): add __Zone_ignore_on_properties to ZoneGlobalConfigurations#50737

Closed
arturovt wants to merge 1 commit intoangular:mainfrom
arturovt:fix/zone-ignore-properties
Closed

fix(zone.js): add __Zone_ignore_on_properties to ZoneGlobalConfigurations#50737
arturovt wants to merge 1 commit intoangular:mainfrom
arturovt:fix/zone-ignore-properties

Conversation

@arturovt
Copy link
Copy Markdown
Contributor

This commit updates the signature of the ZoneGlobalConfigurations interface and adds missing __Zone_ignore_on_properties property, which may be setup to ignore specific on properties from being patched.

@pullapprove pullapprove Bot requested a review from JiaLiPassion June 15, 2023 18:23
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer area: zones Issues related to zone.js labels Jun 16, 2023
@ngbot ngbot Bot added this to the Backlog milestone Jun 16, 2023
…rations`

This commit updates the signature of the `ZoneGlobalConfigurations` interface and adds
missing `__Zone_ignore_on_properties` property, which may be setup to ignore specific `on`
properties from being patched.
@arturovt arturovt force-pushed the fix/zone-ignore-properties branch from 09767dd to c03b188 Compare January 27, 2024 09:36
Copy link
Copy Markdown
Contributor

@JiaLiPassion JiaLiPassion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 31, 2024
jessicajaniuk pushed a commit that referenced this pull request Jan 31, 2024
…rations` (#50737)

This commit updates the signature of the `ZoneGlobalConfigurations` interface and adds
missing `__Zone_ignore_on_properties` property, which may be setup to ignore specific `on`
properties from being patched.

PR Close #50737
@jessicajaniuk
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit f87f058.

@arturovt arturovt deleted the fix/zone-ignore-properties branch January 31, 2024 15:24
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants