docs: fix indentation issue in component lifecycle#50490
docs: fix indentation issue in component lifecycle#50490cadedupont wants to merge 1 commit intoangular:mainfrom cadedupont:indentation-fix
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
JoostK
left a comment
There was a problem hiding this comment.
Please see CONTRIBUTING.md for some instructions on how the PR can be updated.
There was a problem hiding this comment.
You'll want to make the opposite change: replace the tabs in the lines below with 2 spaces each.
|
The changes now look good, but you'll need to combine the two commits into one and rephrase the commit message to align with the convention. You can either run an interactive rebase to Using a soft reset looks something like this: git reset --soft HEAD~2
git commit -am 'docs: fix indentation issue in component lifecycle'
git push --force-with-lease |
|
3rd time's the charm hopefully haha, apologies but thank you for the guidance! :) |
|
This PR was merged into the repository by commit ab35596. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #50488
Tab size differs in code snippet from 2 to 4, modified to make indentation size 4 for entire snippet.
What is the new behavior?
Code indentation is more evenly distributed in lifecycle guide documentation
Does this PR introduce a breaking change?
Other information