Explicitly set non-reactive context when entering user-written code outside of the template update function#49906
Closed
pkozlowski-opensource wants to merge 2 commits intoangular:mainfrom
Conversation
pkozlowski-opensource
force-pushed
the
reactivity_non_reactive_ctx_user_code
branch
4 times, most recently
from
3bb7534 to
6400c34
Compare
pkozlowski-opensource
changed the title
This change explicitly resets a reactive consumer before setting inputs on directive instances. This is to assure that any potential input setters do _not_ run in the reactive context.
pkozlowski-opensource
force-pushed
the
reactivity_non_reactive_ctx_user_code
branch
from
6400c34 to
e93014d
Compare
pkozlowski-opensource
added
action: review
pkozlowski-opensource
added
cross-cutting: signals
target: rc
This commit assures that query results setters run when there is no active reactive consumer set.
pkozlowski-opensource
force-pushed
the
reactivity_non_reactive_ctx_user_code
branch
from
e93014d to
c4c25c6
Compare
atscott
approved these changes
Apr 19, 2023
atscott
added
action: merge
Contributor
|
This PR was merged into the repository by commit 1dc919a. |
angular-robot bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
This change explicitly resets a reactive consumer before setting inputs on directive instances. This is to assure that any potential input setters do _not_ run in the reactive context. PR Close #49906
angular-robot bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
This commit assures that query results setters run when there is no active reactive consumer set. PR Close #49906
angular-robot bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
This commit assures that query results setters run when there is no active reactive consumer set. PR Close #49906
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly set non-reactive context when entering user-written code outside of the template update function:
@Inputsetters