fix(core): ensure takeUntilDestroyed unregisters onDestroy listener on unsubscribe#49901
Closed
skrtheboss wants to merge 1 commit intoangular:mainfrom
Conversation
jessicajaniuk
added
action: cleanup
AndrewKushnir
requested review from
atscott and
pkozlowski-opensource
and removed request for
AndrewKushnir
atscott
requested changes
Apr 18, 2023
Contributor
atscott
left a comment
atscott
left a comment
There was a problem hiding this comment.
Good catch! A couple nits but overall LGTM
skrtheboss
force-pushed
the
fix/ensure-take-until-destroyed-unregisters-on-destroy-listener-on-unsubscribe
branch
from
979f3e3 to
37c7731
Compare
Contributor
Author
|
HI @atscott, thank you for the feedback. |
skrtheboss
force-pushed
the
fix/ensure-take-until-destroyed-unregisters-on-destroy-listener-on-unsubscribe
branch
from
37c7731 to
dd217a3
Compare
…n unsubscribe The takeUntilDestroyed must always remove the onDestroy listener, in the teardown logic.
skrtheboss
force-pushed
the
fix/ensure-take-until-destroyed-unregisters-on-destroy-listener-on-unsubscribe
branch
from
dd217a3 to
2056b03
Compare
atscott
approved these changes
Apr 19, 2023
atscott
added
action: merge
Contributor
|
This PR was merged into the repository by commit c029c67. |
skrtheboss
deleted the
fix/ensure-take-until-destroyed-unregisters-on-destroy-listener-on-unsubscribe
branch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The takeUntilDestroyed function does not remove onDestroy listener on unsubscribe.
What is the new behavior?
The takeUntilDestroyed function removes onDestroy listener on unsubscribe.
Does this PR introduce a breaking change?
Other information