fix(core): Ensure effects can be created when Zone is not defined#49890
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): Ensure effects can be created when Zone is not defined#49890atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
Effects should run in the same zone they were created in. However, if ZoneJS is not used at all, effects should just run (without zone). This is similar to what's done in the elements `ComponentNgElementStrategy`. fixes angular#49798
atscott
added
area: core
alxhub
approved these changes
Apr 17, 2023
Contributor
|
This PR was merged into the repository by commit a49279d. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effects should run in the same zone they were created in. However, if ZoneJS is not used at all, effects should just run (without zone). This is similar to what's done in the elements
ComponentNgElementStrategy.fixes #49798