fix(http): delay accessing pendingTasks.whenAllTasksComplete#49784
Closed
alan-agius4 wants to merge 2 commits intoangular:mainfrom
Closed
fix(http): delay accessing pendingTasks.whenAllTasksComplete#49784alan-agius4 wants to merge 2 commits intoangular:mainfrom
alan-agius4 wants to merge 2 commits intoangular:mainfrom
Conversation
alan-agius4
changed the title
alan-agius4
requested review from
AndrewKushnir
and removed request for
pkozlowski-opensource
alan-agius4
added
target: rc
alan-agius4
force-pushed
the
whenAllTasksComplete
branch
4 times, most recently
from
4171dd0 to
78c32f4
Compare
Contributor
AndrewKushnir
approved these changes
Apr 11, 2023
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Thanks for the fixes @alan-agius4 👍
I've left a minor comment, but let's address it in a followup PR (we can proceed with the merge using the current state).
Another quick question (also for a followup): would it be possible to create a couple test cases for this change, so that we don't regress in the future?
Thank you.
Contributor
There was a problem hiding this comment.
nit: I think it'd be great to add a comment to mention:
- why we do the nesting of promises
- why the
APP_INITIALIZERtoken is used (and the fact that we don't delay the bootstrap, we just subscribe sooner)
AndrewKushnir
added
action: merge
Current in the `InitialRenderPendingTasks` when the `collection` size is 0 a new promise is created a the status is changed to completed. This causes the promise that is created during the class initialization phase to never be resolved which causes SSR to hang indefinitely.
Accessing `pendingTasks.whenAllTasksComplete` too early causes the `InitialRenderPendingTasks` to return a resolved promise too early. This commit changes the way we access `whenAllTasksComplete` to only happen when the application is stabilized.
AndrewKushnir
force-pushed
the
whenAllTasksComplete
branch
from
78c32f4 to
2e30f1b
Compare
Contributor
|
FYI I've pushed a rebase to resolve the merge conflict, which happened around the imports section (no actual conflicts in the logic itself). We can reuse previous g3 presubmit (which was "green") and proceed with the merge. |
Contributor
|
This PR was merged into the repository by commit f9b821f. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 11, 2023
Accessing `pendingTasks.whenAllTasksComplete` too early causes the `InitialRenderPendingTasks` to return a resolved promise too early. This commit changes the way we access `whenAllTasksComplete` to only happen when the application is stabilized. PR Close #49784
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 11, 2023
Accessing `pendingTasks.whenAllTasksComplete` too early causes the `InitialRenderPendingTasks` to return a resolved promise too early. This commit changes the way we access `whenAllTasksComplete` to only happen when the application is stabilized. PR Close #49784
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(http): delay accessing
pendingTasks.whenAllTasksCompleteAccessing
pendingTasks.whenAllTasksCompletetoo early causes theInitialRenderPendingTasksto return a resolved promise too early. This commit changes the way we accesswhenAllTasksCompleteto only happen when the application is stabilized.fix(core): resolve
InitialRenderPendingTaskspromise on completeCurrent in the
InitialRenderPendingTaskswhen thecollectionsize is 0 a new promise is created a the status is changed to completed. This causes the promise that is created during the class initialization phase to never be resolved which causes SSR to hang indefinitely.