feat(platform-browser): enable HTTP request caching when using provideClientHydration#49699
feat(platform-browser): enable HTTP request caching when using provideClientHydration#49699alan-agius4 wants to merge 1 commit intoangular:mainfrom
provideClientHydration#49699Conversation
There was a problem hiding this comment.
Are HydrationFeature and HydrationFeatureKind really needed to be part of the public API? In @angular/common/http I noticed they are but was wondering what they are needed.
There was a problem hiding this comment.
I followed the typings that we have in the Router, but I'm ok with this option too 👍
There was a problem hiding this comment.
Should they still be exported?
There was a problem hiding this comment.
Yeah, we need to export them.
alan-agius4
force-pushed
the
expose-http-cache
branch
from
9c21736 to
1541f5d
Compare
alan-agius4
added
the
target: major
alan-agius4
added
action: review
alan-agius4
force-pushed
the
expose-http-cache
branch
2 times, most recently
from
a6ede8b to
df6bd17
Compare
|
Caretaker note: this requires a G3 patch and BUILD file to be updated. http://cl/521719612 The broken target seems to be caused by other changes in the presubmit CL. |
alan-agius4
added
the
merge: caretaker note
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGTM, just a quick question on the API.
There was a problem hiding this comment.
I followed the typings that we have in the Router, but I'm ok with this option too 👍
…deClientHydration`
This commit adds support by default for HTTP caching when using `provideClientHydration`. Users can opt-out of this behaviour by using the `withoutHttpTransferCache` feature.
```ts
import {
bootstrapApplication,
provideClientHydration,
withNoHttpTransferCache,
} from '@angular/platform-browser';
// ...
bootstrapApplication(RootCmp, {
providers: [provideClientHydration(withNoHttpTransferCache())]
});
```
alan-agius4
force-pushed
the
expose-http-cache
branch
from
df6bd17 to
9e4365c
Compare
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
@alan-agius4 looks great! 👍
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
jessicajaniuk
left a comment
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: fw-core, fw-http, fw-platform-server, public-api
alan-agius4
removed
the
action: review
|
Caretaker notes:
|
|
This PR was merged into the repository by commit 81e7d15. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
This commit adds support by default for HTTP caching when using
provideClientHydration. Users can opt-out of this behaviour by using thewithoutHttpTransferCachefeature.