refactor(forms): Add a test that uses ControlConfig with a non-static validator.#49693
Closed
dylhunn wants to merge 1 commit intoangular:mainfrom
Closed
refactor(forms): Add a test that uses ControlConfig with a non-static validator.#49693dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn wants to merge 1 commit intoangular:mainfrom
Conversation
dylhunn
added
type: bug/fix
action: review
Contributor
Author
|
caretaker note: tap presubmit looks good modulo flakes. |
dylhunn
force-pushed
the
fix-exclude-validatorfn-from-control-config
branch
from
203d39f to
e4fe1ad
Compare
AndrewKushnir
approved these changes
Apr 3, 2023
Member
|
Good catch, |
Contributor
Author
dylhunn
removed
the
action: review
4 tasks
… validator. Previously, this PR cleaned up a bug introduced by angular#48679. However, since that PR needed to be rolled back, this PR now just checks in the test, to prevent that issue from re-occurring in the future.
dylhunn
changed the title
dylhunn
force-pushed
the
fix-exclude-validatorfn-from-control-config
branch
from
e4fe1ad to
b18dd0c
Compare
Contributor
Author
|
This PR was merged into the repository by commit 136ffbc. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this PR cleaned up a bug introduced by #48679. However, since that PR needed to be rolled back, this PR now just checks in the test, to prevent that issue from re-occurring in the future.