Remove deprecated BrowserTransferStateModule#49674
Closed
JeanMeche wants to merge 2 commits intoangular:mainfrom
Closed
Remove deprecated BrowserTransferStateModule#49674JeanMeche wants to merge 2 commits intoangular:mainfrom
BrowserTransferStateModule#49674JeanMeche wants to merge 2 commits intoangular:mainfrom
Conversation
`BrowserTransferStateModule` was deprecated in v14.1 and is empty. It can be removed.
JeanMeche
force-pushed
the
chore/browser-transfer-state-module
branch
from
c479cb1 to
014b094
Compare
This commit provides a migration schematic to remove the usage of the now useless `BrowserTransferStateModule`
JeanMeche
force-pushed
the
chore/browser-transfer-state-module
branch
from
014b094 to
49ad49a
Compare
alan-agius4
added
the
action: review
3 tasks
alan-agius4
removed
the
action: review
Contributor
|
@JeanMeche thanks a lot for creating this PR! We've reviewed the changes and we believe that the schematic might be omitted in this case. To ensue that we land this change in time before the v16 feature freeze (which happens today), we've created a new PR where we cherry-picked your commit that removes the symbol: #49718. We made sure that you are retained as an author of the commit to acknowledge your contribution. Thanks again for your help! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BrowserTransferStateModulewas deprecated in v14.1 and is empty. It can be removed.To ensure a smooth deprecation, a migration schematic is provided.
PR Type
Does this PR introduce a breaking change?