fix(core): ComponentRef.setInput only sets input when not equal to pr…#49607
Closed
atscott wants to merge 2 commits intoangular:mainfrom
Closed
fix(core): ComponentRef.setInput only sets input when not equal to pr…#49607atscott wants to merge 2 commits intoangular:mainfrom
atscott wants to merge 2 commits intoangular:mainfrom
Conversation
atscott
added
area: core
angular-robot
bot
added
the
detected: breaking change
…evious `ComponentRef.setInput` currently sets the input on the component regardless of the previous value the method was called with. This results in different behavior from bindings in templates, which only set inputs when the value differs in the `Object.is` check from its previous value. BREAKING CHANGE: ComponentRef.setInput will only set the input on the component if it is different from the previous value (based on `Object.is` equality). If code relies on the input always being set, it should be updated to copy objects or wrap primitives in order to ensure the input value differs from the previous call to `setInput`.
atscott
force-pushed
the
setInputTracking
branch
from
b3bee60 to
56f3a89
Compare
ajafff
reviewed
Mar 28, 2023
Member
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
Awesome to see this change. Left some nit comments, I think we should just use a map instead of a regular JS object.
Contributor
Author
|
This PR was merged into the repository by commit be23b7c. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…evious
ComponentRef.setInputcurrently sets the input on the component regardless of the previous value the method was called with. This results in different behavior from bindings in templates, which only set inputs when the value differs in theObject.ischeck from its previous value.BREAKING CHANGE: ComponentRef.setInput will only set the input on the component if it is different from the previous value (based on
Object.isequality). If code relies on the input always being set, it should be updated to copy objects or wrap primitives in order to ensure the input value differs from the previous call tosetInput.