feat(core): expose makeStateKey, StateKey and TransferState#49563
Closed
alan-agius4 wants to merge 3 commits intoangular:mainfrom
Closed
feat(core): expose makeStateKey, StateKey and TransferState#49563alan-agius4 wants to merge 3 commits intoangular:mainfrom
makeStateKey, StateKey and TransferState#49563alan-agius4 wants to merge 3 commits intoangular:mainfrom
Conversation
alan-agius4
force-pushed
the
deprecate-transfer-utils-from-platform-browser
branch
from
119aaae to
e3abd03
Compare
angular-robot
bot
added
detected: deprecation
alan-agius4
added
the
target: major
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
deprecate-transfer-utils-from-platform-browser
branch
6 times, most recently
from
e1707ad to
9d25ef6
Compare
Member
|
Would you be interested in a PR providing a migration for that ? |
Contributor
Author
|
@JeanMeche, sure why not. If you want to take a look at a similar migration you can check https://github.com/angular/angular/tree/12.3.x/packages/core/schematics/migrations/xhr-factory |
AndrewKushnir
approved these changes
Mar 27, 2023
AndrewKushnir
approved these changes
Mar 27, 2023
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
jessicajaniuk
approved these changes
Mar 27, 2023
Contributor
jessicajaniuk
left a comment
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: fw-core, fw-platform-server, integration-tests, public-api
alan-agius4
force-pushed
the
deprecate-transfer-utils-from-platform-browser
branch
2 times, most recently
from
269c4a9 to
6fd7e1a
Compare
alan-agius4
added
the
merge: caretaker note
alan-agius4
added
action: merge
alan-agius4
force-pushed
the
deprecate-transfer-utils-from-platform-browser
branch
from
6fd7e1a to
0a891bb
Compare
atscott
force-pushed
the
deprecate-transfer-utils-from-platform-browser
branch
from
0a891bb to
b4a06ec
Compare
This commits adds `makeStateKey`, `StateKey` and `TransferState` methods in `@angular/core` as public API and deprecated the same exported symbols in `@angular/platform-browser`.
DEPRECATED: `makeStateKey`, `StateKey` and `TransferState` exports have been moved from `@angular/platform-browser` to `@angular/core`. Please update the imports.
```diff
- import {makeStateKey, StateKey, TransferState} from '@angular/platform-browser';
+ import {makeStateKey, StateKey, TransferState} from '@angular/core';
```
Co-authored-by: Andrew Kushnir <[email protected]>
alan-agius4
force-pushed
the
deprecate-transfer-utils-from-platform-browser
branch
from
b4a06ec to
afc4d33
Compare
Contributor
|
This PR was merged into the repository by commit c024574. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commits adds
makeStateKey,StateKeyandTransferStatemethods in@angular/coreas public API and deprecated the same exported symbols in@angular/platform-browser.DEPRECATED:
makeStateKey,StateKeyandTransferStateexports have been moved from@angular/platform-browserto@angular/core. Please update the imports.