refactor(core): avoid ngSkipHydration on nodes other than component host ones#49500
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): avoid ngSkipHydration on nodes other than component host ones#49500AndrewKushnir wants to merge 1 commit intoangular:mainfrom
ngSkipHydration on nodes other than component host ones#49500AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
AndrewKushnir
added
action: review
jessicajaniuk
approved these changes
Mar 20, 2023
Contributor
jessicajaniuk
left a comment
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM
We'll need to make sure there's a Runtime Error code added depending on which PR lands first.
AndrewKushnir
added
action: presubmit
Contributor
Author
AndrewKushnir
added
action: merge
Contributor
Author
|
Caretaker note: presubmit is "green", this PR is ready for merge. |
AndrewKushnir
force-pushed
the
validate-skip-hydration
branch
from
f3a47c8 to
ee674e1
Compare
… host ones Angular Hydration uses Components as a hydration boundary, i.e. you can enable/disable hydration on per-component basis. This commit enforces that the `ngSkipHydration` can only be applied on component host nodes (an error if thrown otherwise).
AndrewKushnir
force-pushed
the
validate-skip-hydration
branch
from
ee674e1 to
103f567
Compare
Member
|
This PR was merged into the repository by commit a94b66f. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular Hydration uses Components as hydration boundaries, i.e. you can enable/disable hydration on per-component basis. This commit enforces that the
ngSkipHydrationcan only be applied on component host nodes (an error if thrown otherwise).PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?