Closed
Conversation
alan-agius4
force-pushed
the
remove-server-styles-host
branch
2 times, most recently
from
9cb80f3 to
a0ffe10
Compare
alan-agius4
force-pushed
the
remove-server-styles-host
branch
17 times, most recently
from
b6e33da to
2f7319a
Compare
alan-agius4
added
action: review
AndrewKushnir
approved these changes
Mar 15, 2023
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
@alan-agius4 thanks for the refactoring! 👍 The changes look great!
alan-agius4
force-pushed
the
remove-server-styles-host
branch
from
4828ced to
989f3bd
Compare
alan-agius4
added
action: merge
With the recent changes and refactors of `dom_renderer` having a separate `ServerStylesHost` is redundant.
…StylesHost` The mentioned 2 classes have been combined since it is no longer required to have a separate `SharedStylesHost` for SSR. This changes also reduces the memory usage footprint as remove 1 Map that stores the CSS strings.
…`SharedStylesHost`
…`SharedStylesHost`
alan-agius4
force-pushed
the
remove-server-styles-host
branch
4 times, most recently
from
a0bf7ce to
ae70a38
Compare
Contributor
Author
|
|
…p-id` `ng-app` is an AngularJS attribute, see https://docs.angularjs.org/api/ng/directive/ngApp. Using this attribute on a non AngularJS element can cause DI issues in AngularJS when running an AngularJS and Angular application on the same page. As such, we avoid such problems the Angular `ng-app` attribute is renamed to `ng-app-id`.
alan-agius4
force-pushed
the
remove-server-styles-host
branch
from
ae70a38 to
9e04222
Compare
Member
|
This PR was merged into the repository by commit 9636910. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Mar 17, 2023
…p-id` (#49424) `ng-app` is an AngularJS attribute, see https://docs.angularjs.org/api/ng/directive/ngApp. Using this attribute on a non AngularJS element can cause DI issues in AngularJS when running an AngularJS and Angular application on the same page. As such, we avoid such problems the Angular `ng-app` attribute is renamed to `ng-app-id`. PR Close #49424
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(platform-browser): combine
DomSharedStylesHostandSharedStylesHostThe mentioned 2 classes have been combined since it is no longer required to have a separate
SharedStylesHostfor SSR. This changes also reduces the memory usage footprint as remove 1 Map that stores the CSS strings.refactor(platform-server): remove
ServerStylesHostWith the recent changes and refactors of
dom_rendererhaving a separateServerStylesHostis redundant.refactor(platform-browser): rename
ng-appstyle attribute tong-app-idng-appis an AngularJS attribute, see https://docs.angularjs.org/api/ng/directive/ngApp. Using this attribute on a non AngularJS element can cause DI issues in AngularJS when running an AngularJS and Angular application on the same page.As such, we avoid such problems the Angular
ng-appattribute is renamed tong-app-id.