refactor(compiler): required inputs prerequisite refactors#49333
Closed
crisbeto wants to merge 2 commits intoangular:mainfrom
Closed
refactor(compiler): required inputs prerequisite refactors#49333crisbeto wants to merge 2 commits intoangular:mainfrom
crisbeto wants to merge 2 commits intoangular:mainfrom
Conversation
crisbeto
added
action: review
crisbeto
force-pushed
the
required-inputs-prereq
branch
9 times, most recently
from
66001cf to
60510c7
Compare
crisbeto
commented
Mar 7, 2023
packages/compiler-cli/src/ngtsc/metadata/src/property_mapping.ts
Outdated
Show resolved
Hide resolved
crisbeto
commented
Mar 7, 2023
crisbeto
commented
Mar 7, 2023
Member
Author
crisbeto
added
merge: caretaker note
JoostK
reviewed
Mar 8, 2023
packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/metadata/src/property_mapping.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/metadata/src/property_mapping.ts
Outdated
Show resolved
Hide resolved
alxhub
requested changes
Mar 10, 2023
crisbeto
force-pushed
the
required-inputs-prereq
branch
2 times, most recently
from
452455e to
75193e5
Compare
Member
Author
JoostK
approved these changes
Mar 13, 2023
Member
JoostK
left a comment
JoostK
left a comment
There was a problem hiding this comment.
I like the cleanup around ClassPropertyMapping! Some nits for your consideration but otherwise LGTM
packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/annotations/directive/src/symbol.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/metadata/src/property_mapping.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/metadata/src/property_mapping.ts
Outdated
Show resolved
Hide resolved
alxhub
approved these changes
Mar 13, 2023
Based on the discussion in angular#49304 (comment). Reworks the compiler internals to allow for additional information about inputs to be stored. This is a prerequisite for required inputs.
crisbeto
force-pushed
the
required-inputs-prereq
branch
from
75193e5 to
28ecb80
Compare
Member
Author
|
Almost passing TGP. There's one unrelated failure. |
crisbeto
added
action: merge
Member
|
This PR was merged into the repository by commit be97c87. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #49304 (comment). Reworks the compiler internals to allow for additional information about inputs to be stored. This is a prerequisite for required inputs.