Skip to content

fix(router): Remove deprecated ComponentFactoryResolver from APIs#49239

Closed
atscott wants to merge 3 commits intoangular:mainfrom
atscott:removeComponentFactoryResolverFromRouter
Closed

fix(router): Remove deprecated ComponentFactoryResolver from APIs#49239
atscott wants to merge 3 commits intoangular:mainfrom
atscott:removeComponentFactoryResolverFromRouter

Conversation

@atscott
Copy link
Copy Markdown
Contributor

@atscott atscott commented Feb 27, 2023

BREAKING CHANGE:
ComponentFactoryResolver has been removed from Router APIs. Component factories are not required to create an instance of a component dynamically. Passing a factory resolver via resolver argument is no longer needed and code can instead use ViewContainerRef.createComponent without the factory resolver.

@atscott atscott added breaking changes target: major This PR is targeted for the next major release labels Feb 27, 2023
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Feb 27, 2023
AndrewKushnir
AndrewKushnir approved these changes Feb 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup 👍

@JeanMeche
Copy link
Copy Markdown
Member

JeanMeche commented Feb 28, 2023

nit: You could also remove the line in the depreciation guide !

@ngbot ngbot bot added this to the Backlog milestone Feb 28, 2023
@atscott atscott added the action: global presubmit The PR is in need of a google3 global presubmit label Feb 28, 2023
@atscott atscott force-pushed the removeComponentFactoryResolverFromRouter branch from 1a72197 to 285a505 Compare February 28, 2023 22:43
dylhunn
dylhunn approved these changes Feb 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from alxhub February 28, 2023 22:44
pkozlowski-opensource
pkozlowski-opensource approved these changes Mar 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

atscott added 2 commits March 9, 2023 10:18
@atscott
fix(router): Remove deprecated ComponentFactoryResolver from APIs
aacd5f9 
BREAKING CHANGE:
`ComponentFactoryResolver` has been removed from Router APIs.
Component factories are not required to create an instance of a component
dynamically. Passing a factory resolver via resolver argument is no longer needed
and code can instead use `ViewContainerRef.createComponent` without the
factory resolver.
@atscott
docs: remove deprecation notes for removed APIs
c824e8a 
This commit removes the deprecation notes from the deprecations guide for APIs that have been removed.
@atscott atscott force-pushed the removeComponentFactoryResolverFromRouter branch from 285a505 to c824e8a Compare March 9, 2023 18:19
@atscott
Copy link
Copy Markdown
Contributor Author

atscott commented Mar 10, 2023

TGP

@atscott atscott removed the action: global presubmit The PR is in need of a google3 global presubmit label Mar 10, 2023
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Mar 10, 2023
@ngbot
Copy link
Copy Markdown

ngbot bot commented Mar 10, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alxhub
Copy link
Copy Markdown
Member

alxhub commented Mar 14, 2023

This PR was merged into the repository by commit ed110a0.

@alxhub alxhub closed this in c0b1b7b Mar 14, 2023
alxhub pushed a commit that referenced this pull request Mar 14, 2023
@atscott @alxhub
docs: remove deprecation notes for removed APIs (#49239)
ed110a0 
This commit removes the deprecation notes from the deprecations guide for APIs that have been removed.

PR Close #49239
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Apr 14, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

+1 more reviewer

@dylhunn dylhunn dylhunn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker breaking changes detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

6 participants

@atscott @JeanMeche @alxhub @pkozlowski-opensource @dylhunn @AndrewKushnir