feat(router): Expose information about the last successful Navigation#49235
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
feat(router): Expose information about the last successful Navigation#49235atscott wants to merge 1 commit intoangular:mainfrom
Navigation#49235atscott wants to merge 1 commit intoangular:mainfrom
Conversation
The `Router` already has the `getCurrentNavigation()` helper function to expose information about the ongoing navigation. `lastSuccessfulNavigation` is actually already exposed in the `Navigation` object. This commit only _slightly_ extends the current API surface by providing access to the `lastSuccessfulNavigation` object outside of an ongoing navigation. fixes angular#45685
atscott
added
feature
pullapprove
bot
requested review from
AndrewKushnir,
alxhub and
pkozlowski-opensource
AndrewKushnir
approved these changes
Feb 27, 2023
AndrewKushnir
approved these changes
Feb 27, 2023
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
pkozlowski-opensource
approved these changes
Mar 2, 2023
Member
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
pkozlowski-opensource
added
the
action: review
atscott
added
action: merge
pkozlowski-opensource
approved these changes
Mar 2, 2023
Member
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
jessicajaniuk
added
the
merge: caretaker note
Contributor
|
This PR was merged into the repository by commit ea32c32. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Routeralready has thegetCurrentNavigation()helper function to expose information about the ongoing navigation.lastSuccessfulNavigationis actually already exposed in theNavigationobject. This commit only slightly extends the current API surface by providing access to thelastSuccessfulNavigationobject outside of an ongoing navigation.fixes #45685