fix(platform-server): bundle @angular/domino in via esbuild#49229
Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
Closed
fix(platform-server): bundle @angular/domino in via esbuild#49229jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
Conversation
jessicajaniuk
added
action: review
jessicajaniuk
force-pushed
the
domino-bundle
branch
5 times, most recently
from
036a2c6 to
5ec63eb
Compare
This removes one line that should effectively bundle the angular fork of domino in via esbuild.
jessicajaniuk
force-pushed
the
domino-bundle
branch
from
5ec63eb to
c0c2221
Compare
devversion
approved these changes
Feb 28, 2023
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM.
Note: We have considered publishing to npm directly, but it would still require changes in all these places + we would need a release setup/process for the fork.
jessicajaniuk
added
action: merge
Contributor
Author
|
Caretaker: This requires a patch to be merged before landing this PR, which means the G3 test shouldn't matter. I'll run them anyway. |
Member
|
cc. @josephperrott in case he also wants to have a look. |
Contributor
|
This PR was merged into the repository by commit a08a8ff. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes one line that should effectively bundle the angular fork of domino in via esbuild.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We're not bundling @angular/domino in with platform-server.
Issue Number: #49228
What is the new behavior?
We are bundling @angular/domino in with platform-server.
Does this PR introduce a breaking change?
Other information