feat(core): add support for TypeScript 5.0#49126
feat(core): add support for TypeScript 5.0#49126crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
added
action: review
crisbeto
force-pushed
the
ts-5
branch
2 times, most recently
from
1793668 to
c050f3b
Compare
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM, just a few small questions on additional context.
There was a problem hiding this comment.
Does this mean that the source mappings are incorrect? well, I guess, they were a little incorrect anyway if they included the \n}\n?
There was a problem hiding this comment.
tbh, I'm not sure, as you said a correct mapping wouldn't include the newlines. It's possible that this is just how our testing utilities work.
There was a problem hiding this comment.
Is there any context on this change? (if you recall, can be in the comment here)
There was a problem hiding this comment.
The internal typings changed from readonly NONE: number to readonly NONE: 0 so our mock had to be updated as well.
packages/compiler-cli/package.json
Outdated
There was a problem hiding this comment.
Just picking this place for the comment: Are there things we need to keep in mind with the decorator changes. i.e. when applications don't have --experimentalDecorators=true? https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#differences-with-experimental-legacy-decorators
There was a problem hiding this comment.
For the moment if apps disable experimentalDecorators, they'll get a compilation error on parameter decorators before the code even reaches our compiler. I think that eventually we'll have a schematic to move apps away from constructor injection.
Updates the project to support TypeScript 5.0 and to resolve any errors that came up as a result of the update.
crisbeto
added
action: merge
|
This PR was merged into the repository by commit 99d874f. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Updates the project to support TypeScript 5.0 and to resolve any errors that came up as a result of the update.