feat: remove Angular Compatibility Compiler (ngcc)#49101
Closed
alan-agius4 wants to merge 2 commits intoangular:mainfrom
Closed
feat: remove Angular Compatibility Compiler (ngcc)#49101alan-agius4 wants to merge 2 commits intoangular:mainfrom
alan-agius4 wants to merge 2 commits intoangular:mainfrom
Conversation
angular-robot
bot
added
detected: breaking change
alan-agius4
force-pushed
the
remove-ngcc
branch
2 times, most recently
from
18eb2bb to
e21d72d
Compare
alan-agius4
added
the
area: compiler
alan-agius4
force-pushed
the
remove-ngcc
branch
from
e21d72d to
2a7679e
Compare
alan-agius4
force-pushed
the
remove-ngcc
branch
3 times, most recently
from
4634f36 to
3cbfb17
Compare
This commit removes the NGCC code and all the related infra setup required to support it. BREAKING CHANGE: Angular Compatibility Compiler (ngcc) has been removed and as a result Angular View Engine libraries will no longer work
alan-agius4
force-pushed
the
remove-ngcc
branch
from
3cbfb17 to
af98c1b
Compare
alan-agius4
added
the
action: review
alxhub
approved these changes
Feb 16, 2023
Member
alxhub
left a comment
alxhub
left a comment
There was a problem hiding this comment.
Thanks, ngcc ❤️ but you will not be missed
twerske
approved these changes
Feb 16, 2023
Contributor
twerske
left a comment
twerske
left a comment
There was a problem hiding this comment.
lgtm on the docs changes
pullapprove
bot
requested review from
alxhub,
atscott and
pkozlowski-opensource
alxhub
approved these changes
Feb 16, 2023
Member
alxhub
left a comment
alxhub
left a comment
There was a problem hiding this comment.
Reviewed-for: global-approvers
pkozlowski-opensource
approved these changes
Feb 16, 2023
Member
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
alan-agius4
added
action: merge
JoostK
approved these changes
Feb 16, 2023
alan-agius4
added
the
target: major
atscott
approved these changes
Feb 16, 2023
jessicajaniuk
approved these changes
Feb 16, 2023
Contributor
jessicajaniuk
left a comment
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api, code-ownership
Member
|
This PR was merged into the repository by commit 48aa96e. |
2 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the NGCC code and all the related infra setup required to support it.
BREAKING CHANGE: Angular Compatibility Compiler (ngcc) has been removed and as a result Angular View Engine libraries will no longer work