perf(core): change RendererType2.styles to accept only a flat array#49072
Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Closed
perf(core): change RendererType2.styles to accept only a flat array#49072alan-agius4 wants to merge 1 commit intoangular:mainfrom
RendererType2.styles to accept only a flat array#49072alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
alan-agius4
force-pushed
the
styles-array
branch
from
aff8e66 to
28404b9
Compare
angular-robot
bot
added
the
detected: breaking change
alan-agius4
force-pushed
the
styles-array
branch
from
28404b9 to
8ff6550
Compare
alan-agius4
added
the
target: major
alan-agius4
added
the
action: review
AndrewKushnir
approved these changes
Feb 15, 2023
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
@alan-agius4 looks great, thanks for the cleanup 👍
AndrewKushnir
changed the title
RendererType2.styles to accept a only a flat arrayRendererType2.styles to accept a only a flat array
jessicajaniuk
approved these changes
Feb 15, 2023
Contributor
jessicajaniuk
left a comment
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: fw-core, fw-platform-server, public-api
AndrewKushnir
approved these changes
Feb 15, 2023
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
AndrewKushnir
removed
the
action: review
Contributor
Author
|
Will wait on #48298 before merging to avoid conflicts for the patch branch. |
While unlikely, prior to this change it was possible to provide a nested array of styles to the render. This required the framework to handle this by doing a flatten operation. This change also renames the `flattenStyles` method as it no longer flattens the styles. BREAKING CHANGE: `RendererType2.styles` no longer accepts a nested arrays. Closes angular#48317
alan-agius4
force-pushed
the
styles-array
branch
from
8ff6550 to
c9bd865
Compare
alan-agius4
added
action: merge
Contributor
|
This PR was merged into the repository by commit 9b9c818. |
alan-agius4
changed the title
RendererType2.styles to accept a only a flat arrayRendererType2.styles to accept only a flat array
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While unlikely, prior to this change it was possible to provide a nested array of styles to the render. This required the framework to handle this by doing a flatten operation. This change also renames the
flattenStylesmethod as it no longer flattens the styles.BREAKING CHANGE:
RendererType2.stylesno longer accepts a nested arrays.Closes #48317