fix(platform-browser): reuse server generated component styles#48253
Closed
alan-agius4 wants to merge 8 commits intoangular:mainfrom
Closed
fix(platform-browser): reuse server generated component styles#48253alan-agius4 wants to merge 8 commits intoangular:mainfrom
alan-agius4 wants to merge 8 commits intoangular:mainfrom
Conversation
alan-agius4
added
area: core
alan-agius4
force-pushed
the
re-use-style
branch
from
14eea7b to
5340146
Compare
alan-agius4
force-pushed
the
re-use-style
branch
11 times, most recently
from
ca1ca9b to
c1b61a5
Compare
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
@alan-agius4 thanks for the PR 👍
The approach looks promising, I've just left a few minor comments/questions.
plamoni
reviewed
Nov 28, 2022
alan-agius4
force-pushed
the
re-use-style
branch
from
c1b61a5 to
a73124b
Compare
alan-agius4
commented
Nov 29, 2022
alan-agius4
force-pushed
the
re-use-style
branch
3 times, most recently
from
29c2b40 to
fee45a5
Compare
alfaproject
reviewed
Nov 30, 2022
alan-agius4
force-pushed
the
re-use-style
branch
from
f4b0d52 to
b9cde15
Compare
alan-agius4
force-pushed
the
re-use-style
branch
from
c14ccad to
1a83fb9
Compare
alan-agius4
added
action: merge
alan-agius4
removed
action: merge
Contributor
|
After additional research, it turned out that styles might have source maps on a server, thus causing a discrepancy: Thanks @yharaskrik for the help with troubleshooting! 👍 |
alan-agius4
force-pushed
the
re-use-style
branch
5 times, most recently
from
d007c01 to
76c5ae3
Compare
AndrewKushnir
approved these changes
Mar 6, 2023
alan-agius4
added
the
action: cleanup
alan-agius4
force-pushed
the
re-use-style
branch
from
f9f5092 to
3533a29
Compare
Prior to this change the component IDs where generated based on a counter. This is problematic as there is no guarantee that a component will get the same ID that was assigned on the server when generated on the client side. This is paramount to be able to re-use the component styles generated on the server.
Prior to this change component styles generated on the server where removed prior to the client side component being rendered and attached it's own styles. In some cases this caused flickering. To mitigate this `initialNavigation: enabledBlocking'` was introduced which allowed the remove of server styles to be defer to a latter stage when the application has finished initialization. This commit changes the need for this, by not removing the server generated component styles and reuse them for client side rendering.
This was a mirror copy of the `APP_ID` token.
alan-agius4
removed
the
action: cleanup
AndrewKushnir
approved these changes
Mar 9, 2023
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
@alan-agius4 looks great, thanks for working on this change! 👍
Contributor
|
(adding the "merge" label after an LGTM from @alan-agius4) |
Contributor
|
This PR was merged into the repository by commit 86fc4d3. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(core): generate consistent component IDs
Prior to this change the component IDs where generated based on a counter. This is problematic as there is no guarantee that a component will get the same ID that was assigned on the server when generated on the client side.
This is paramount to be able to re-use the component styles generated on the server.
fix(platform-browser): reuse server generated component styles
Prior to this change component styles generated on the server where removed prior to the client side component being rendered and attached it's own styles. In some cases this caused flickering. To mitigate this
initialNavigation: enabledBlocking'was introduced which allowed the remove of server styles to be defer to a latter stage when the application has finished initialization.This commit changes the need for this, by not removing the server generated component styles and reuse them for client side rendering.
refactor(platform-browser): remove internal
TRANSITION_IDtokenThis was a mirror copy of the
APP_IDtoken.