fix(router): Ensure anchor scrolling happens on ignored same URL navigations#48025
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(router): Ensure anchor scrolling happens on ignored same URL navigations#48025atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
angular-robot
bot
added
detected: breaking change
atscott
force-pushed
the
navigationCancelOnIgnore
branch
from
2da5f46 to
682707a
Compare
pullapprove
bot
requested review from
alxhub,
jessicajaniuk and
pkozlowski-opensource
pkozlowski-opensource
added
the
action: cleanup
atscott
removed
the
action: cleanup
atscott
force-pushed
the
navigationCancelOnIgnore
branch
from
682707a to
7db94b7
Compare
pkozlowski-opensource
added
the
action: cleanup
Member
|
cleanup: CI is failing, looks like the PR still needs golden file update. |
atscott
removed
the
action: cleanup
atscott
force-pushed
the
navigationCancelOnIgnore
branch
from
7db94b7 to
adde971
Compare
jessicajaniuk
approved these changes
Nov 14, 2022
Contributor
jessicajaniuk
left a comment
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
pkozlowski-opensource
approved these changes
Nov 15, 2022
Member
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
atscott
force-pushed
the
navigationCancelOnIgnore
branch
from
adde971 to
8207176
Compare
atscott
force-pushed
the
navigationCancelOnIgnore
branch
from
8207176 to
42d0402
Compare
atscott
force-pushed
the
navigationCancelOnIgnore
branch
from
42d0402 to
b8b58a5
Compare
…gations The Router scroller only listens for NavigationEnd events. However, the default behavior of the Router is to ignore navigations to the same URL. This breaks the anchor scrolling when clicking on an anchor whose fragment is already in the URL. fixes angular#29099 BREAKING CHANGE: The `Scroll` event's `routerEvent` property may also be a `NavigationSkipped` event. Previously, it was only a `NavigationEnd` event.
atscott
force-pushed
the
navigationCancelOnIgnore
branch
from
b8b58a5 to
89b9772
Compare
Contributor
|
This PR was merged into the repository by commit 1f055b9. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Router scroller only listens for NavigationEnd events. However, the
default behavior of the Router is to ignore navigations to the same URL.
This breaks the anchor scrolling when clicking on an anchor whose
fragment is already in the URL.
fixes #29099
BREAKING CHANGE: The
Scrollevent'srouterEventproperty may also bea
NavigationSkippedevent. Previously, it was only aNavigationEndevent.