refactor(compiler): replace most usages of getMutableClone #47167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
get-mutable-clone
branch
5 times, most recently
from
04302bd to
0b6bc0a
Compare
crisbeto
added
area: compiler
Member
Author
crisbeto
added
the
action: review
devversion
approved these changes
Aug 17, 2022
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM for the trivial tslint, but I also looked at the downlevel transform I added in the past..
packages/compiler-cli/test/downlevel_decorators_transform_spec.ts
Outdated
Show resolved
Hide resolved
...mpiler-cli/src/transformers/downlevel_decorators_transform/downlevel_decorators_transform.ts
Outdated
Show resolved
Hide resolved
crisbeto
force-pushed
the
get-mutable-clone
branch
from
0b6bc0a to
69d0bde
Compare
JoostK
reviewed
Aug 17, 2022
packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.ts
Outdated
Show resolved
Hide resolved
...mpiler-cli/src/transformers/downlevel_decorators_transform/downlevel_decorators_transform.ts
Outdated
Show resolved
Hide resolved
Replaces (almost) all of the usages of the deprecated `getMutableClone` function from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove.
crisbeto
force-pushed
the
get-mutable-clone
branch
from
bfbf192 to
a375b68
Compare
crisbeto
force-pushed
the
get-mutable-clone
branch
from
a375b68 to
e025da2
Compare
crisbeto
added
action: merge
Member
|
This PR was merged into the repository by commit ddb95c5. |
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Aug 26, 2022
…7167) Replaces (almost) all of the usages of the deprecated `getMutableClone` function from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove. PR Close angular#47167
alxhub
pushed a commit
that referenced
this pull request
Aug 26, 2022
…47271) Replaces (almost) all of the usages of the deprecated `getMutableClone` function from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove. PR Close #47167 PR Close #47271
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces (almost) all of the usages of the deprecated
getMutableClonefunction from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove.