Skip to content

Revert "fix(animations): enable shadowElements to leave when their parent does (#46459)"#46739

Closed
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz:revert-shadow-dom-leave
Closed

Revert "fix(animations): enable shadowElements to leave when their parent does (#46459)"#46739
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz:revert-shadow-dom-leave

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Contributor

This reverts commit b417370.

The change applied is no longer appropriate since the use of animations
and shadow dom components is discouraged (as of #46738)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe: reverting a previously made change which is no longer appropriate

Issue

Issue Number: N/A

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…rent does (angular#46459)"

This reverts commit b417370.

The change applied is no longer appropriate since the use of animations
and shadow dom components is discouraged (as of angular#46738)
@pullapprove pullapprove bot requested a review from alxhub July 7, 2022 16:04

private _signalRemovalForInnerTriggers(rootElement: any, context: any) {
const elements = this._engine.driver.query(rootElement, NG_TRIGGER_SELECTOR, true);
const shadowElements = rootElement.shadowRoot ?
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crisbeto this removes the issue with the edge case you pointed out here 🙂

@jessicajaniuk jessicajaniuk added target: patch This PR is targeted for the next patch release area: animations legacy animations package only. Otherwise use area: core. labels Jul 7, 2022
@ngbot ngbot bot added this to the Backlog milestone Jul 7, 2022
Copy link
Copy Markdown
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core, fw-animations

@jessicajaniuk jessicajaniuk removed the request for review from alxhub July 7, 2022 20:17
@jessicajaniuk jessicajaniuk added the action: merge The PR is ready for merge by the caretaker label Jul 7, 2022
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Jul 7, 2022

This PR was merged into the repository by commit b3c20ad.

@alxhub alxhub closed this in b3c20ad Jul 7, 2022
alxhub pushed a commit that referenced this pull request Jul 7, 2022
…rent does (#46459)" (#46739)

This reverts commit b417370.

The change applied is no longer appropriate since the use of animations
and shadow dom components is discouraged (as of #46738)

PR Close #46739
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: animations legacy animations package only. Otherwise use area: core. target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants