feat(common): make the CommonModule pipes standalone
#46401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
state: WIP
area: common
AndrewKushnir
force-pushed
the
common_pipes_standalone
branch
3 times, most recently
from
f374037 to
12e8af1
Compare
AndrewKushnir
added
action: review
This commit updates the pipes presents in the `CommonModule` and annotates them with the `standalone: true` flag. With that flag, the pipes can now be imported individually, as well as imported via the `CommonModule`.
AndrewKushnir
force-pushed
the
common_pipes_standalone
branch
from
12e8af1 to
dc9c472
Compare
Contributor
Author
3 tasks
pkozlowski-opensource
approved these changes
Jun 23, 2022
Member
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-core
jessicajaniuk
approved these changes
Jun 23, 2022
jessicajaniuk
added
action: merge
Contributor
|
This PR was merged into the repository by commit 4a2e733. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the pipes presents in the
CommonModuleand annotates them with thestandalone: trueflag. With that flag, the pipes can now be imported individually, as well as imported via theCommonModule.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?