feat(upgrade): more closely align UpgradeModule#bootstrap() with angular.bootstrap()
#46214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
type: bug/fix
area: upgrade
gkalpak
changed the title
angular.bootstrap()UpgradeModule#bootstrap() with angular.bootstrap()
gkalpak
force-pushed
the
fix-upgrade-bootstrap
branch
from
9d850dd to
22085c3
Compare
|
You can preview 22085c3 at https://pr46214-22085c3.ngbuilds.io/. |
gkalpak
force-pushed
the
fix-upgrade-bootstrap
branch
from
22085c3 to
c16a2d6
Compare
Add some tests for the `UpgradeModule` class and its members.
…ngular.bootstrap()` Previously, [UpgradeModule#bootstrap()][1], while being a replacement for and accepting the same arguments as [angular.bootstrap()][2], did not return the same value as `angular.bootstrap()` (i.e. the AngularJS injector in most cases). This made it less straight forward to migrate some usecases that relied on the return value of `.bootstrap()`. The work-around was to access the injector via [UpgradeModule#$injector][3] (after the app had been bootstrapped with `UpgradeModule#bootstrap()`). This commit addresses this by ensuring `UpgradeModule#bootstrap()` returns the same value as `angular.bootstrap()`, making it easier to replace the latter with the former. [1]: https://angular.io/api/upgrade/static/UpgradeModule#bootstrap [2]: https://docs.angularjs.org/api/ng/function/angular.bootstrap [3]: https://angular.io/api/upgrade/static/UpgradeModule#%24injector Fixes angular#46211
gkalpak
added
the
action: review
pullapprove
bot
requested review from
alxhub,
jessicajaniuk and
pkozlowski-opensource
AndrewKushnir
approved these changes
Jun 2, 2022
AndrewKushnir
approved these changes
Jun 2, 2022
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
jessicajaniuk
approved these changes
Jun 2, 2022
Contributor
jessicajaniuk
left a comment
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: fw-upgrade, public-api
gkalpak
added
action: merge
Member
|
This PR was merged into the repository by commit e9cb045. |
alxhub
pushed a commit
that referenced
this pull request
Jun 3, 2022
…ngular.bootstrap()` (#46214) Previously, [UpgradeModule#bootstrap()][1], while being a replacement for and accepting the same arguments as [angular.bootstrap()][2], did not return the same value as `angular.bootstrap()` (i.e. the AngularJS injector in most cases). This made it less straight forward to migrate some usecases that relied on the return value of `.bootstrap()`. The work-around was to access the injector via [UpgradeModule#$injector][3] (after the app had been bootstrapped with `UpgradeModule#bootstrap()`). This commit addresses this by ensuring `UpgradeModule#bootstrap()` returns the same value as `angular.bootstrap()`, making it easier to replace the latter with the former. [1]: https://angular.io/api/upgrade/static/UpgradeModule#bootstrap [2]: https://docs.angularjs.org/api/ng/function/angular.bootstrap [3]: https://angular.io/api/upgrade/static/UpgradeModule#%24injector Fixes #46211 PR Close #46214
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, UpgradeModule#bootstrap(), while being a replacement for and accepting the same arguments as angular.bootstrap(), did not return the same value as
angular.bootstrap()(i.e. the AngularJS injector in most cases). This made it less straight forward to migrate some usecases that relied on the return value of.bootstrap(). The work-around was to access the injector via UpgradeModule#$injector (after the app had been bootstrapped withUpgradeModule#bootstrap()).This commit addresses this by ensuring
UpgradeModule#bootstrap()returns the same value asangular.bootstrap(), making it easier to replace the latter with the former.Fixes #46211.