feat(http): improve error message for nullish header #46059
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markostanimirovic
force-pushed
the
feat/http/nullish-header-error-message
branch
from
0bee9b2 to
bbc0bd0
Compare
AndrewKushnir
added
action: review
markostanimirovic
force-pushed
the
feat/http/nullish-header-error-message
branch
2 times, most recently
from
6a77b4b to
98fa657
Compare
AndrewKushnir
requested changes
Jun 14, 2022
This commit improves the error message for nullish headers. Fixes angular#46048
markostanimirovic
force-pushed
the
feat/http/nullish-header-error-message
branch
from
98fa657 to
c646140
Compare
AndrewKushnir
approved these changes
Jun 16, 2022
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
@markostanimirovic thanks for addressing the feedback. The change looks good 👍
I've also ran tests in Google's codebase (internal link) and they came back as "green".
AndrewKushnir
added
action: merge
Contributor
|
This PR was merged into the repository by commit 82acbf9. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #46048
What is the new behavior?
Improved error message for nullish headers.
Does this PR introduce a breaking change?