Repository navigation
Conversation
Contributor
Author
|
@JiaLiPassion friendly ping :) |
arturovt
force-pushed
the
fix/43206-silence-finally
branch
from
June 18, 2022 19:08
53bff0b to
bfeb553
Compare
JiaLiPassion
suggested changes
Jun 19, 2022
arturovt
force-pushed
the
fix/43206-silence-finally
branch
2 times, most recently
from
June 19, 2022 20:21
e0baa6c to
411e235
Compare
…nally` is called The native promise implementation logs unhandled promise rejections after `onFinally` has been called. We may rely on the `scheduledByFinally` argument, which is `false` by default, to avoid creating a breaking change; this will also allow us to reduce the number of changes. The `finally` function should not silence unhandled promise rejections, because they're not silenced in any implementation. If the `scheduleResolveOrReject` is called within the `finally` we won't clear unhandled rejections. We'll keep the same behaviour if the `scheduleResolveOrReject` is called within the `then`. PR Close angular#43206
arturovt
force-pushed
the
fix/43206-silence-finally
branch
from
June 19, 2022 20:35
411e235 to
5bd2487
Compare
JiaLiPassion
approved these changes
Jun 19, 2022
JiaLiPassion
left a comment
JiaLiPassion
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for the fix.
JiaLiPassion
added
target: minor
Contributor
|
This PR was merged into the repository by commit cb57cdb. |
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
Jun 22, 2022
… the `finally` is called (angular#45449)" This reverts commit cb57cdb.
Contributor
AndrewKushnir
added a commit
that referenced
this pull request
Jun 22, 2022
3 tasks done
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native promise implementation logs unhandled promise rejections after
onFinallyhas been called. We may rely on the
scheduledByFinallyargument, which isfalsebydefault, to avoid creating a breaking change; this will also allow us to reduce the number of
changes. The
finallyfunction should not silence unhandled promise rejections, becausethey're not silenced in any implementation. If the
scheduleResolveOrRejectis called withinthe
finallywe won't clear unhandled rejections. We'll keep the same behaviour if thescheduleResolveOrRejectis called within thethen.PR Checklist
PR Type
What is the current behavior?
Issue Number: #43206
Does this PR introduce a breaking change?