Skip to content

perf(animations): Remove generic objects in favor of Maps#44482

Closed
jessicajaniuk wants to merge 1 commit intoangular:masterfrom
jessicajaniuk:animation-maps
Closed

perf(animations): Remove generic objects in favor of Maps#44482
jessicajaniuk wants to merge 1 commit intoangular:masterfrom
jessicajaniuk:animation-maps

Conversation

@jessicajaniuk
Copy link
Copy Markdown
Contributor

@jessicajaniuk jessicajaniuk commented Dec 14, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

We were using a number of generic objects as if they were maps and relying on delete to remove
properties.

Issue Number: N/A

What is the new behavior?

In order to improve performance, these generic objects have been switched to native maps.

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk jessicajaniuk force-pushed the animation-maps branch 2 times, most recently from e233f8f to be7e805 Compare December 14, 2021 23:52
@jessicajaniuk jessicajaniuk added the area: animations legacy animations package only. Otherwise use area: core. label Dec 14, 2021
@ngbot ngbot Bot added this to the Backlog milestone Dec 14, 2021
@jessicajaniuk jessicajaniuk added the target: patch This PR is targeted for the next patch release label Dec 14, 2021
jessicajaniuk
jessicajaniuk commented Dec 15, 2021
View reviewed changes
Comment thread packages/animations/src/animation_metadata.ts Outdated
@jessicajaniuk jessicajaniuk force-pushed the animation-maps branch 5 times, most recently from f2c3799 to 24cacd0 Compare December 15, 2021 01:15
AndrewKushnir
AndrewKushnir reviewed Dec 15, 2021
View reviewed changes
Comment thread packages/animations/browser/src/dsl/animation_ast_builder.ts Outdated
Comment thread packages/animations/browser/src/dsl/animation_ast_builder.ts Outdated
Comment thread packages/animations/browser/src/dsl/animation_ast_builder.ts Outdated
Comment thread packages/animations/browser/src/dsl/animation_ast_builder.ts Outdated
Comment thread packages/animations/browser/src/render/timeline_animation_engine.ts Outdated
Comment thread packages/animations/browser/src/render/timeline_animation_engine.ts Outdated
Comment thread packages/animations/browser/src/render/transition_animation_engine.ts Outdated
Comment thread packages/animations/browser/src/render/transition_animation_engine.ts Outdated
Comment thread packages/animations/browser/src/render/timeline_animation_engine.ts Outdated
Comment thread packages/animations/browser/src/render/shared.ts Outdated
@jessicajaniuk jessicajaniuk force-pushed the animation-maps branch 9 times, most recently from 74bec63 to 84cc81b Compare December 16, 2021 23:12
dario-piotrowicz
dario-piotrowicz reviewed Dec 20, 2021
View reviewed changes
Comment thread packages/animations/browser/src/dsl/animation_timeline_builder.ts Outdated
dario-piotrowicz
dario-piotrowicz reviewed Dec 20, 2021
View reviewed changes
Comment thread packages/animations/browser/src/render/special_cased_styles.ts Outdated
dario-piotrowicz
dario-piotrowicz reviewed Dec 20, 2021
View reviewed changes
Comment thread packages/animations/browser/src/render/special_cased_styles.ts Outdated
dario-piotrowicz
dario-piotrowicz reviewed Dec 20, 2021
View reviewed changes
Comment thread packages/animations/browser/src/render/timeline_animation_engine.ts Outdated
Comment thread packages/animations/browser/src/render/transition_animation_engine.ts Outdated
Comment thread packages/animations/browser/src/util.ts Outdated
Comment thread packages/animations/browser/src/util.ts Outdated
dario-piotrowicz
dario-piotrowicz reviewed Dec 20, 2021
View reviewed changes
Comment thread packages/animations/browser/src/render/shared.ts Outdated
@jessicajaniuk jessicajaniuk force-pushed the animation-maps branch 4 times, most recently from 0e15016 to 9698f71 Compare December 21, 2021 23:34
@pullapprove pullapprove Bot requested a review from alxhub January 5, 2022 03:36
atscott
atscott approved these changes Jan 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove Bot requested a review from AndrewKushnir January 5, 2022 17:26
@jessicajaniuk jessicajaniuk force-pushed the animation-maps branch 7 times, most recently from 6437971 to 54e52f8 Compare January 5, 2022 20:42
@jessicajaniuk jessicajaniuk added breaking changes target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jan 5, 2022
@jessicajaniuk jessicajaniuk force-pushed the animation-maps branch 4 times, most recently from 8954cb4 to 24b7039 Compare January 5, 2022 22:43
@jessicajaniuk jessicajaniuk modified the milestones: Backlog, v14-candidates Jan 6, 2022
dylhunn
dylhunn approved these changes Jan 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@dario-piotrowicz dario-piotrowicz mentioned this pull request Jan 22, 2022
Closed
14 tasks
dario-piotrowicz
dario-piotrowicz reviewed Jan 24, 2022
View reviewed changes
Comment thread packages/animations/browser/src/dsl/animation_ast_builder.ts Outdated
Comment on lines 304 to 305
Copy link
Copy Markdown
Contributor

@dario-piotrowicz dario-piotrowicz Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessicajaniuk In PR #44729 I am adding a delete tuple[prop] here, after the PR has been merged please remember to update it to tuple.delete(prop) whenever you can 🙂

Original discussion: https://github.com/angular/angular/pull/44729/files#r787206809

dylhunn
dylhunn approved these changes Jan 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core, fw-testing, public-api

@jessicajaniuk
Copy link
Copy Markdown
Contributor Author

jessicajaniuk commented Jan 31, 2022

TGP is green

AndrewKushnir
AndrewKushnir approved these changes Jan 31, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

Comment thread goldens/public-api/animations/browser/testing/testing.md Outdated
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I like the StyleData as a symbol name a bit more. The Map part leaks the implementation detail into the name (for ex. we'd need to change the name if we later decide to use an array).

This is a very minor thing, not a blocker for this PR :)

Copy link
Copy Markdown
Contributor Author

@jessicajaniuk jessicajaniuk Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually agree, but we still use the old symbol. We'd need a new name. I'll think on it for a potential refactor after this PR.

@thePunderWoman
perf(animations): Remove generic objects in favor of Maps
0234c7e 
We were using a number of generic objects as if they were maps and relying on delete to remove
properties. In order to improve performance, these have been switched to native maps.
@jessicajaniuk
Copy link
Copy Markdown
Contributor Author

jessicajaniuk commented Jan 31, 2022

This PR was merged into the repository by commit 7a81481.

@alfaproject
Copy link
Copy Markdown
Contributor

alfaproject commented Jan 31, 2022

@jessicajaniuk OOC do you have performance numbers before/after?

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Mar 3, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

+2 more reviewers

@dario-piotrowicz dario-piotrowicz dario-piotrowicz left review comments

@dylhunn dylhunn dylhunn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: animations legacy animations package only. Otherwise use area: core. breaking changes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Milestone

v14-candidates

Development

Successfully merging this pull request may close these issues.

7 participants

@jessicajaniuk @alfaproject @atscott @dylhunn @AndrewKushnir @dario-piotrowicz @thePunderWoman